search

conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
9 stars 22 forks source link

Support {{ compiler('mpi') }} #110

Open isuruf opened 2 years ago

isuruf commented 2 years ago

Comment:

This way, we can setup cross compiling env things like OPAL_PREFIX and build_env compiler. Also, we can remove hacks like https://github.com/conda-forge/conda-smithy/blob/52db47bc3064f2471c1c8927c02d1149014557fa/conda_smithy/configure_feedstock.py#L280

cc @minrk, @beckermr

leofang commented 2 years ago

Sounds like an alternative solution to #91 to me? (xref: https://github.com/conda-forge/conda-forge.github.io/pull/1752) cc: @carterbox

jakirkham commented 2 years ago

cc @dalcinl

dalcinl commented 2 years ago

Perhaps it should be compiler('mpicc'), compiler('mpicxx'), compiler('mpifort')? Recipes may need only one, or two, or all of them. Depending on the actual semantics of compiler('mpi'), my comment may be irrelevant. Perhaps the idea is that compiler('mpi') alone is meaningless and should error, unless something like compiler('c') is also present.

Or perhaps the compiler(...) thing could be extended such that it could be used the following way:

{{ compiler('c', 'mpi') }}
{{ compiler('cxx', 'mpi') }}
{{ compiler('fortran', 'mpi') }}

Beside these minor details about defining actual semantics, this is a great idea!