recipe: Add libnl dependency on Linux

conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.

BSD 3-Clause "New" or "Revised" License

9 stars 25 forks source link

Closed dalcinl closed 9 months ago

dalcinl commented 9 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalcinl commented 9 months ago

@leofang What about zlib? Should we perhaps use libzlib in the run section to not depend in the whole zlib package? https://github.com/conda-forge/zlib-feedstock/blob/main/recipe/meta.yaml

leofang commented 9 months ago

Took a quick look, we need zlib in host, because it offers the headers. But we can remove it from run, because zlib run_exports libzlib

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

leofang commented 9 months ago

It's just time out, let's merge and retry on main. Thanks, Lisandro!