conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
9 stars 22 forks source link

Rebuild for libhwloc 2.9.3 #141

Closed regro-cf-autotick-bot closed 5 months ago

regro-cf-autotick-bot commented 5 months ago

This PR has been triggered in an effort to update libhwloc293.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/7645341919, please use this URL for debugging.

conda-forge-webservices[bot] commented 5 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalcinl commented 5 months ago

@leofang @minrk The migrator moved this recipe to use cross-compilation for linux-aarch64. I pushed a quick fix assuming without checking that Fortran datatypes have the same size/alignment in osx-arm64 and linux-aarch64.

dalcinl commented 5 months ago

BTW, now that we are at it, why don't we just cross-compile in linux-ppc64le as well?

leofang commented 5 months ago

Interesting that you made it work, if the assumption holds it'd be nice to cross compile, see the earlier discussion here https://github.com/conda-forge/openmpi-feedstock/pull/121#issuecomment-1880248274.

dalcinl commented 5 months ago

cross-compiled linux builds are tested under emulation

Oh, boy... I didn't know cross-compiled packages were tested under emulation! I'll definitely try to switch ppc64le to cross-compilation.

dalcinl commented 5 months ago

@leofang @minrk I'm way out of my comfort zone with this PR. May I ask for your quick review again? The various config variables in cross-gfortran.$target_arch.sh were obtained fresh with runs on native macOS arm64 and emulated aarch64/ppc64le under popman.

leofang commented 5 months ago

cross-compiled linux builds are tested under emulation

Oh, boy... I didn't know cross-compiled packages were tested under emulation! I'll definitely try to switch ppc64le to cross-compilation.

Note: this is because we set test_on_native_only: True, which is deprecated and mapped to test: native_and_emulated. So we get the QEMU for free when cross compiling.

The various config variables in cross-gfortran.$target_arch.sh were obtained fresh with runs on native macOS arm64 and emulated aarch64/ppc64le under popman.

@dalcinl Could you add a note to educate us how it was generated? I keep asking the original authors on both mpich/openmpi feedstocks and no one responded. If you figured it out, let's make sure I and future us know how to maintain.

dalcinl commented 5 months ago

@leofang You are asking me to write down documentation. How dare you?

dalcinl commented 5 months ago

Are the comments I added good enough?

leofang commented 5 months ago

For some reason the linux64 CI has failed repeatedly, seems related to some invalid utf-8 characters detected by LIEF at run time. https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=866388&view=logs&jobId=aaada960-d85f-5b88-82e5-99df4d27a2ce&j=aaada960-d85f-5b88-82e5-99df4d27a2ce&t=0aca0cbb-1f96-540a-bae4-6a7030c11d7d

dalcinl commented 5 months ago

What are we supposed to do? Should we try triggering a new build?

leofang commented 5 months ago

Asking in the CF Gitter channel, let's see if anyone can help... I haven't seen this before

dalcinl commented 5 months ago

Any news? Out of better ideas, I just restarted the build.

leofang commented 5 months ago

Error reproduced in #142.