conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
10 stars 25 forks source link

Add `sysroot` to `requirements/build` #145

Closed jakirkham closed 8 months ago

jakirkham commented 9 months ago

In PR ( https://github.com/conda-forge/openmpi-feedstock/pull/121 ), the linux-64 builds were updated to an image based on CentOS 7, which was mentioned here ( https://github.com/conda-forge/openmpi-feedstock/pull/121#discussion_r1443658627 ). However the packages don't currently factor this into the __glibc version constraint

This PR fixes that by adding the sysroot package pinned to 2.17, which is what CentOS 7 uses. As sysroot has a __glibc run_exports/strong constraint, this is added to the build & host environment as well as the final package dependencies


Checklist

conda-forge-webservices[bot] commented 9 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 9 months ago

Seeing the same issue as PR: https://github.com/conda-forge/openmpi-feedstock/pull/142

leofang commented 8 months ago

@jakirkham since we're rebuilding the package to fix the upload issue, would you like me to move your change there (#142)?

jakirkham commented 8 months ago

Sure if you would like to have it there

Am also ok waiting until the current issues are resolved

jakirkham commented 8 months ago

Done in PR: https://github.com/conda-forge/openmpi-feedstock/pull/142

leofang commented 8 months ago

Thanks for help John! 🙏 Yes I rebased your commit against #142.

jakirkham commented 8 months ago

Thanks Leo! 🙏