conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
10 stars 25 forks source link

Require GLIBC 2.17+ in MPI compilers #147

Closed jakirkham closed 7 months ago

jakirkham commented 7 months ago

Fixes https://github.com/conda-forge/openmpi-feedstock/issues/143

Adds sysroot_{{ target_platform }} 2.17 to requirements/build of MPI compiler packages. This will make GLIBC 2.17 a minimum requirement at install time.


Checklist

conda-forge-webservices[bot] commented 7 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 7 months ago

How do we handle build number bumps for these packages?

jakirkham commented 7 months ago

We are already using sysroot above. This is just trying to fix a user problem

If someone wants to migrate this feedstock great, but please handle that separately

beckermr commented 7 months ago

Totally make sense @jakirkham. Indeed a separate PR is better! LGTM and thank you!

jakirkham commented 7 months ago

Marking as draft until we figure out how to handle the build/number here. Just want to make sure we handle that correctly

beckermr commented 7 months ago

What is the question about the build number specifically?

I'd argue we bump it to get a working build and also apply patches to the problematic older builds.

leofang commented 7 months ago

Thanks, @jakirkham, this looks good to me. Is there anything else needed before merging?

jakirkham commented 7 months ago

If the build number bump looks good, then this should be ready to go

leofang commented 7 months ago

Thanks, John!

jakirkham commented 7 months ago

Thanks Leo and Matt! 🙏

jakirkham commented 7 months ago

We should use the new stdlib stuff, right?

Handling the {{ stdlib('c') }} pieces in PR: https://github.com/conda-forge/openmpi-feedstock/pull/149