Closed jakirkham closed 7 months ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
How do we handle build number bumps for these packages?
We are already using sysroot
above. This is just trying to fix a user problem
If someone wants to migrate this feedstock great, but please handle that separately
Totally make sense @jakirkham. Indeed a separate PR is better! LGTM and thank you!
Marking as draft until we figure out how to handle the build/number
here. Just want to make sure we handle that correctly
What is the question about the build number specifically?
I'd argue we bump it to get a working build and also apply patches to the problematic older builds.
Thanks, @jakirkham, this looks good to me. Is there anything else needed before merging?
If the build
number bump looks good, then this should be ready to go
Thanks, John!
Thanks Leo and Matt! 🙏
We should use the new stdlib stuff, right?
Handling the {{ stdlib('c') }}
pieces in PR: https://github.com/conda-forge/openmpi-feedstock/pull/149
Fixes https://github.com/conda-forge/openmpi-feedstock/issues/143
Adds
sysroot_{{ target_platform }} 2.17
torequirements/build
of MPI compiler packages. This will make GLIBC 2.17 a minimum requirement at install time.Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)