only set wrapper args for cross compilation, keeping subset of LDFLAGS necessary for sysroot < 2.17

conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.

BSD 3-Clause "New" or "Revised" License

9 stars 22 forks source link

only set wrapper args for cross compilation, keeping subset of LDFLAGS necessary for sysroot < 2.17 #159

Closed minrk closed 3 weeks ago

minrk commented 3 weeks ago

defaults are not likely to be wrong for native compilation, don't mess with them, I think #158 went a bit too far.

and don't passthrough $LDFLAGS, etc. from compiler activation, set the actual correct values from the wrappers with the right prefix.

closes #163

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

minrk commented 3 weeks ago

Still need to update the tests

minrk commented 3 weeks ago

I'd really like to land this to unbreak things caused by #158. If folks are still uncomfortable with including the link flag from $LDFLAGS, I can remove it and isolate that to its own PR.

minrk commented 3 weeks ago

I will merge this today unless there are objections, to prevent more conflicts like #162, since all questions raised so far have been addressed. To reiterate, this PR applies a strict subset of flags than the currently published build, it does not add any. It's just that one (the one that's necessary for building in conda-forge default environments) is now called out by name.