Make activate script POSIX-compatible.

conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.

BSD 3-Clause "New" or "Revised" License

9 stars 22 forks source link

Closed ktlim closed 3 weeks ago

ktlim commented 3 weeks ago

The activate script can be run in a number of shells, not just bash, so it should only use POSIX-compatible syntax.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 3 weeks ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

timj commented 3 weeks ago

Are we going to get the same problem on line 9 of the script?

github-actions[bot] commented 3 weeks ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!

ktlim commented 3 weeks ago

Oops, I moved too fast. @timj you should have pushed an additional fix before the bot got to it :)