Disable CUDA awareness by default

leofang commented 4 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Close #55.

leofang commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 years ago

@jakirkham I looked at the CI output but didn't find the post-link message shows up. Is this expected?

I also tried installing drmaa locally, and didn't see the post-link message either...

leofang commented 4 years ago

@dalcinl Thanks. I thought about it too. Is 2462aa1 better?

jakirkham commented 4 years ago

I looked at the CI output but didn't find the post-link message shows up. Is this expected?

Hmm...I wouldn't expect that. Maybe raise a conda-build issue and see what they say?

jakirkham commented 4 years ago

We might also need some code like this to plugin this script.

leofang commented 4 years ago

@beckermr: Matt, any idea why the post-link script didn't print out to the console?

jakirkham commented 4 years ago

@leofang, did you already add the code above to the build script?

leofang commented 4 years ago

Seems to be working: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=126268&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=6d4b912b-175d-51da-0fd9-4d30fe1eb4e7&l=21371 but it looks weird, let me try not write to .messages.txt.

It's odd that this extra code is needed but isn't documented!

jakirkham commented 4 years ago

Yeah the .message.txt is needed to avoid having log messages from packages intermingled with Conda output in an unreadable way.

beckermr commented 4 years ago

Yes you have to write to the messages.txt

leofang commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

jakirkham commented 4 years ago

Thoughts @conda-forge/openmpi? 🙂

jakirkham commented 4 years ago

Do you have thoughts on how we could improve the messaging further? 🙂

beckermr commented 4 years ago

An activation script would be more noisy but in general there is not much we can do.

leofang commented 4 years ago

@conda-forge-admin, please rerender

leofang commented 4 years ago

Rerendering never completed?!

@conda-forge-admin, please rerender

beckermr commented 4 years ago

See here: https://github.com/conda-forge/openmpi-feedstock/runs/495849112?check_suite_focus=true

You are getting an error pushing to your repo.

jakirkham commented 4 years ago

How are we doing the push? Do we use git@github.com:<user>/<repo>.git or are we using https://? Asking as the latter IIRC does not work if the user has 2FA enabled.

beckermr commented 4 years ago

@jakirkham I have 2FA and have had no problems with it pushing to my branches...

leofang commented 4 years ago

Rerendered locally. Not sure what's wrong, though. I have activated my 2FA for a long time and never had a problem until now...Re-kicking it off just for testing.

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 4 years ago

Alright, so looks like the bot was updated during this period, but without rerendering manually the new bot can't accept the job...Thanks, @beckermr!

But, why is the osx job cancelled? It says

This job was temporarily blocked because it uses a Microsoft hosted agent (MacOS-10.13) that will be permanently removed on March 23rd, 2020. See https://aka.ms/blocked-hosted-agent for more information.

Does it mean we can't build osx packages for the moment?

beckermr commented 4 years ago

@conda-forge/core @isuruf looks like azure is getting serious about this osx image issue

leofang commented 4 years ago

For this PR it's OK, though. The OS X package doesn't get any update other than a pure book-keeping bump in the build number.

@dalcinl This is in your hands now.

dalcinl commented 4 years ago

@dalcinl This is in your hands now.

What do you mean? Do you just want me to click the merge button?

jakirkham commented 4 years ago

@conda-forge-admin, please re-render.

jakirkham commented 4 years ago

looks like azure is getting serious about this osx image issue

@leofang I think this got fixed in conda-smithy 3.6.11. So a re-render should fix it.

beckermr commented 4 years ago

@conda-forge-admin rerender

beckermr commented 4 years ago

@conda-forge-admin recipe lint

beckermr commented 4 years ago

@conda-forge-admin lint

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 years ago

@beckermr @jakirkham Thanks for the update!

@dalcinl Yes, please feel free to merge this.

leofang commented 4 years ago

Ah, one more question: do you mind if I add myself to the recipe maintainer list?

dalcinl commented 4 years ago

Ah, one more question: do you mind if I add myself to the recipe maintainer list?

YES, PLEASE!!! Do it right now and ping me back for merge.

leofang commented 4 years ago

@conda-forge-admin, please rerender

leofang commented 4 years ago

@dalcinl Done.

leofang commented 4 years ago

@dalcinl All checks passed.

jakirkham commented 4 years ago

Thanks @leofang for the PR and everyone for all the reviews! 😄

leofang commented 4 years ago

Thanks to you all, @dalcinl @jakirkham @beckermr!

leofang commented 4 years ago

The post-link output is really ugly...

$ conda create -n mpi_test -c conda-forge python=3.7 mpi4py openmpi
Collecting package metadata (current_repodata.json): done
Solving environment: done

==> WARNING: A newer version of conda exists. <==
  current version: 4.7.12
  latest version: 4.8.3

Please update conda by running

    $ conda update -n base -c defaults conda

## Package Plan ##

  environment location: /home/leofang/miniconda3/envs/mpi_test

  added / updated specs:
    - mpi4py
    - openmpi
    - python=3.7

The following packages will be downloaded:

    package                    |            build
    ---------------------------|-----------------
    ca-certificates-2020.4.5.1 |       hecc5488_0         146 KB  conda-forge
    certifi-2020.4.5.1         |   py37hc8dfbb8_0         151 KB  conda-forge
    mpi-1.0                    |          openmpi           4 KB  conda-forge
    mpi4py-3.0.3               |   py37hbfacf26_1         647 KB  conda-forge
    openmpi-4.0.2              |       hdf1f1ad_4         3.9 MB  conda-forge
    setuptools-46.1.3          |   py37hc8dfbb8_0         634 KB  conda-forge
    xz-5.2.5                   |       h516909a_0         430 KB  conda-forge
    ------------------------------------------------------------
                                           Total:         5.9 MB

The following NEW packages will be INSTALLED:

  _libgcc_mutex      conda-forge/linux-64::_libgcc_mutex-0.1-conda_forge
  _openmp_mutex      conda-forge/linux-64::_openmp_mutex-4.5-0_gnu
  ca-certificates    conda-forge/linux-64::ca-certificates-2020.4.5.1-hecc5488_0
  certifi            conda-forge/linux-64::certifi-2020.4.5.1-py37hc8dfbb8_0
  ld_impl_linux-64   conda-forge/linux-64::ld_impl_linux-64-2.34-h53a641e_0
  libffi             conda-forge/linux-64::libffi-3.2.1-he1b5a44_1007
  libgcc-ng          conda-forge/linux-64::libgcc-ng-9.2.0-h24d8f2e_2
  libgfortran-ng     conda-forge/linux-64::libgfortran-ng-7.3.0-hdf63c60_5
  libgomp            conda-forge/linux-64::libgomp-9.2.0-h24d8f2e_2
  libstdcxx-ng       conda-forge/linux-64::libstdcxx-ng-9.2.0-hdf63c60_2
  mpi                conda-forge/linux-64::mpi-1.0-openmpi
  mpi4py             conda-forge/linux-64::mpi4py-3.0.3-py37hbfacf26_1
  ncurses            conda-forge/linux-64::ncurses-6.1-hf484d3e_1002
  openmpi            conda-forge/linux-64::openmpi-4.0.2-hdf1f1ad_4
  openssl            conda-forge/linux-64::openssl-1.1.1f-h516909a_0
  pip                conda-forge/noarch::pip-20.0.2-py_2
  python             conda-forge/linux-64::python-3.7.6-h8356626_5_cpython
  python_abi         conda-forge/linux-64::python_abi-3.7-1_cp37m
  readline           conda-forge/linux-64::readline-8.0-hf8c457e_0
  setuptools         conda-forge/linux-64::setuptools-46.1.3-py37hc8dfbb8_0
  sqlite             conda-forge/linux-64::sqlite-3.30.1-hcee41ef_0
  tk                 conda-forge/linux-64::tk-8.6.10-hed695b0_0
  wheel              conda-forge/noarch::wheel-0.34.2-py_1
  xz                 conda-forge/linux-64::xz-5.2.5-h516909a_0
  zlib               conda-forge/linux-64::zlib-1.2.11-h516909a_1006

Proceed ([y]/n)? 

Downloading and Extracting Packages
openmpi-4.0.2        | 3.9 MB    | ############################################################################################################################ | 100% 
mpi4py-3.0.3         | 647 KB    | ############################################################################################################################ | 100% 
mpi-1.0              | 4 KB      | ############################################################################################################################ | 100% 
ca-certificates-2020 | 146 KB    | ############################################################################################################################ | 100% 
setuptools-46.1.3    | 634 KB    | ############################################################################################################################ | 100% 
certifi-2020.4.5.1   | 151 KB    | ############################################################################################################################ | 100% 
xz-5.2.5             | 430 KB    | ############################################################################################################################ | 100% 
Preparing transaction: done
Verifying transaction: done
Executing transaction: \ b' \nFor Linux 64, Open MPI is built with CUDA awareness but this support is disabled by default.\nTo enable it, please set the environmental variable OMPI_MCA_opal_cuda_support=true before\nlaunching your MPI processes. Equivalently, you can set the MCA parameter in the command line:\nmpiexec --mca opal_cuda_support 1 ...\n \n'
done
#
# To activate this environment, use
#
#     $ conda activate mpi_test
#
# To deactivate an active environment, use
#
#     $ conda deactivate

beckermr commented 4 years ago

file a fix on the conda side I supposed

leofang commented 4 years ago

Thanks, Matt. I did already file an issue in https://github.com/conda/conda-build/issues/3883. I tried searching how pre-/post- link scripts are printed, but I couldn't figure it out...

beckermr commented 4 years ago

This happens in conda/conda, not conda/conda-build.

leofang commented 4 years ago

Ahhh, thanks for the pointer! Will take a look later.

conda-forge / openmpi-feedstock

Disable CUDA awareness by default #56