conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
9 stars 25 forks source link

openmpi v4.0.3 #57

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [ ] Dependencies have been updated if changed: see upstream
    • [ ] Tests have passed
    • [ ] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.

NEW: If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our new bot automerge feature to your feedstock!

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/15641, please use this URL for debugging

Here is a list of all the pending dependencies (and their versions) for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
openmpi 4.0.3 Anaconda-Server Badge
conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

leofang commented 4 years ago

It seems the patch added in #52 can be removed. The patch is from open-mpi/ompi#7122 / open-mpi/ompi#7193 and is merged to and available in v4.0.3.

leofang commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 4 years ago

@conda-forge-admin, please lint

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

dalcinl commented 4 years ago
  • License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

@leofang Maybe we need to use license: BSD-3-Clause ?

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 years ago

@conda-forge-admin, please lint

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 4 years ago

@dalcinl Thanks! Looks like the bot is happy now.

@xylar Am I right about https://github.com/conda-forge/openmpi-feedstock/pull/57#issuecomment-610185252?

xylar commented 4 years ago

@leofang, I had to refresh my memory about this :-). I imagine that the patch has already been incorporated upstream so, yes, let's remove it at see how it goes.

dalcinl commented 4 years ago

@leofang Ready to merge?

leofang commented 4 years ago

Yes I think so. The drone CI is completed but the return code was not captured for some reason.

dalcinl commented 4 years ago

@leofang @jsquyres Something is going on on macOS, look in the logs for the following output showing up after mpiexec invocations.

[Mac-1270.local:86722] PMIX ERROR: ERROR in file gds_ds12_lock_pthread.c at line 206

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=141078&view=logs&jobId=ce7cbaa7-582c-5570-40f4-267b3d85fc9f&j=ce7cbaa7-582c-5570-40f4-267b3d85fc9f&t=4a56039b-7269-50ae-de7a-538e91e6de06

leofang commented 4 years ago

Seems like this issue will be sticking around for a while: open-mpi/ompi#7516. @dalcinl, should I mark the OS X package as broken for the time being?

leofang commented 4 years ago

...or we can rebuild the OS X package with an additional env var PMIX_MCA_gds=hash as suggested in the linked issue (and then mark build 0 as broken).

leofang commented 4 years ago

A separate question is: Why didn't the CI test fail on OS X? Is it because the error happens at cleanup?

leofang commented 4 years ago

...yet another question: @beckermr, could you help me investigate why we aren't building a package for linux-ppc64le? I just checked and found that the linux-ppc64le build has been missing since #56, but in #54 it was still there. I didn't do anything that would disable this AFAIK...

leofang commented 4 years ago

should I mark the OS X package as broken for the time being?

See conda-forge/cf-mark-broken#36.

dalcinl commented 4 years ago

A separate question is: Why didn't the CI test fail on OS X? Is it because the error happens at cleanup?

Oh, you should ask the Open MPI folks. Obviously that error did not propagate up to mpiexec to return with error.

leofang commented 4 years ago

why we aren't building a package for linux-ppc64le?

Ping @conda-forge/core for help.

beckermr commented 4 years ago

IDK about the ppce64le build. Is it enabled in the conda-forge.yaml and did the CI run on this PR?

leofang commented 4 years ago

Addressing both OS X and ppc64le issues in #58. Let's move the discussion there, thanks!