conda-forge / openmpi-feedstock

A conda-smithy repository for openmpi.
BSD 3-Clause "New" or "Revised" License
9 stars 25 forks source link

Fix CUDA awareness #84

Closed leofang closed 3 years ago

leofang commented 3 years ago

Checklist

Close #83. Fix a silly mistake that I made in #80...😞

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

leofang commented 3 years ago

@conda-forge-admin, please rerender

jakirkham commented 3 years ago

Should the run_constrained in meta.yaml also be updated?

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

leofang commented 3 years ago

Should the run_constrained in meta.yaml also be updated?

No, because we can support any CUDA version. Open MPI does not care. I set it to 9.2 only because it's the oldest version available on CF.

jakirkham commented 3 years ago

Ok didn't know if we would run into issues since we are actually building against CUDA 10.2

leofang commented 3 years ago

Right, we made sure of that earlier. Open MPI does not rely on any CUDA runtime API, only driver ones. It dlopen libcuda.so at runtime. It has been the case since CUDA 6 (?). There are some weird CUDA version check at build time that should have been removed (https://github.com/open-mpi/ompi/issues/7334).

leofang commented 3 years ago

Travis is dead 😞

@conda-forge-admin please restart ci

leofang commented 3 years ago

osx segfaults...?

leofang commented 3 years ago

@conda-forge-admin please restart ci

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

leofang commented 3 years ago

I manually restarted Travis, but if it fails the 3rd time, I will merge anyway. It's been in a poor state in weeks and not getting any better: https://gitter.im/conda-forge-ppc64le/Lobby

leofang commented 3 years ago

...and it failed again as I typed.

leofang commented 3 years ago

Merging, and will restart manually until the package is out, although the ppc64le package built on Travis is not impacted by my silly mistake, so it's fine to not upload a new one. In the near future let's look for other alternatives, maybe cross-compiling?

leofang commented 3 years ago

Merging, and will restart manually until the package is out

The merge commit built successfully.

jakirkham commented 2 years ago

Sorry for missing this before, but should these lines have been updated to CUDA 10.2 as well?

https://github.com/conda-forge/openmpi-feedstock/blob/fde85a81ef3e94a6714d4227e9968e59da19300e/recipe/meta.yaml#L47-L48