conda-forge / openpmd-api-feedstock

A conda-smithy repository for openpmd-api.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

rebuild for hdf5 1.14.1 #107

Closed minrk closed 1 year ago

minrk commented 1 year ago

The bot claims that this repo has already been migrated, but no PR was issued. Not sure why it thinks this is the case.

This should get adios2 2.9.1, which has been built with hdf5 1.14.1.

closes https://github.com/conda-forge/adios2-feedstock/issues/78

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

minrk commented 1 year ago

Some builds are failing with a test timeout:

6/9 Test #6: Asynchronous.10_streaming ........***Timeout 1500.10 sec
Current iteration: 0

while the mac arm+openmpi builds are failing at FindHDF5 in cmake. Not sure why, because the error isn't actually shown. I'm not sure what's different about hdf5 1.14 vs 1.12 here, but there have been issues with cmake changes in 1.14. But the ones I'm aware of were fixed in 1.14.1, though there may be more.

ax3l commented 1 year ago

@franzpoeschel interesting that a series of streaming tests times out. I will restart (linux_64 w/ MPICH; osx x64 w/ MPICH and osx arm64 w/ OpenMPI):

6/9 Test #6: Asynchronous.10_streaming ........***Timeout 1500.08 sec
Current iteration: 0
franzpoeschel commented 1 year ago

For MPICH builds, this PR should fix the hangups

ax3l commented 1 year ago

Argh, macOS arm64:

-- Found HDF5: $PREFIX/lib/libhdf5.dylib (found version "") found components: C 
CMake Error at CMakeLists.txt:373 (message):
  Found HDF5 version is too old.  At least version 1.8.13 is required.

  If you manually installed a version of HDF5 in a non-default path, add its
  installation prefix to the environment variable CMAKE_PREFIX_PATH to find
  it: https://cmake.org/cmake/help/latest/envvar/CMAKE_PREFIX_PATH.html

Looks like CMake cannot find the HDF5 version for this particular CF build.

I thought I already patched this broken version check out in 0.14.0+: https://github.com/openPMD/openPMD-api/pull/1027

But it looks like HDF5_VERSION is unset for some reason on macOS arm64 on CF: https://github.com/openPMD/openPMD-api/blob/0.15.1/CMakeLists.txt#L337C26-L337C38