Fix osx clang - Githubissues

conda-forge / openpmd-api-feedstock

A conda-smithy repository for openpmd-api.

BSD 3-Clause "New" or "Revised" License

1 stars 6 forks source link

Fix osx clang #14

Closed mingwandroid closed 5 years ago

mingwandroid commented 5 years ago

Checklist

[x] Used a fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mingwandroid commented 5 years ago

@ax3l please review, there's more to do though, not all test files are being downloaded (also we should move downloading the test repo into meta.yaml via multiple sources).

ax3l commented 5 years ago

Hm, the Serial.SerialIO test on OSX with clang is still showing the segfault we wanted to get out: https://travis-ci.org/conda-forge/openpmd-api-feedstock/jobs/475174977

mingwandroid commented 5 years ago

The segfault use likely due to missing test files again, despite downloading these ones. Please see my comment on gitter

ax3l commented 5 years ago

It should actually work without them, this is just a diagnostic message that a test is skipped: https://github.com/openPMD/openPMD-api/blob/4cbe73c1f824b6d8509131fffe6adc20f7670cdc/test/SerialIOTest.cpp#L1034-L1037

I applied your changes in #13 and did not download the sample files as before. If you want to download them here (can not push to this branch), just replace bash with source.

ax3l commented 5 years ago

Closing this for fix in #20. Thanks again for your great help! :)