Closed ax3l closed 5 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Oh no, I just learned that we falsely assumed that Library\lib
would work and be in %PATH%
on user systems.
Turns out, it is not and this is a defect :(
Ref.: https://github.com/ContinuumIO/anaconda-issues/issues/233#issuecomment-184455643
No detail on this in the official docs: https://docs.conda.io/projects/conda-build/en/latest/user-guide/environment-variables.html#environment-variables-set-during-the-build-process
We should go to Library\bin
instead, which is in %PATH%
...
cc @sdebionne
Ah all good, our .dll
is indeed installed in Library\bin
:)
I just learned that unix-like packages on conda-forge should be installed in a
\Library
prefix :) https://docs.conda.io/projects/conda-build/en/latest/user-guide/environment-variables.html#environment-variables-set-during-the-build-processhttps://github.com/conda-forge/pybind11-feedstock/issues/30 Thanks @sdebionne !
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)