conda-forge / openpmd-api-feedstock

A conda-smithy repository for openpmd-api.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Rebuild for hdf51121 #83

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update hdf51121.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

This package has the following downstream children:

And potentially more.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1529715027, please use this URL for debugging

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ax3l commented 2 years ago

Not clear why this migration causes OpenMPI and MPICH not to be found anymore on aarch64 and pcc64le for CMake

ax3l commented 2 years ago

Before this PR on aarch64 running on Azure:

+CMAKE_ARGS=-DCMAKE_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ar -DCMAKE_CXX_COMPILER_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_C_COMPILER_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ranlib -DCMAKE_CXX_COMPILER_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_C_COMPILER_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_LINKER=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ld -DCMAKE_STRIP=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-strip -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY -DCMAKE_FIND_ROOT_PATH=$PREFIX;$BUILD_PREFIX/aarch64-conda-linux-gnu/sysroot -DCMAKE_INSTALL_PREFIX=$PREFIX -DCMAKE_INSTALL_LIBDIR=lib

and after:

+CMAKE_ARGS=-DCMAKE_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ar -DCMAKE_CXX_COMPILER_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_C_COMPILER_AR=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ar -DCMAKE_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ranlib -DCMAKE_CXX_COMPILER_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_C_COMPILER_RANLIB=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-gcc-ranlib -DCMAKE_LINKER=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-ld -DCMAKE_STRIP=$BUILD_PREFIX/bin/aarch64-conda-linux-gnu-strip -DCMAKE_FIND_ROOT_PATH_MODE_PROGRAM=NEVER -DCMAKE_FIND_ROOT_PATH_MODE_LIBRARY=ONLY -DCMAKE_FIND_ROOT_PATH_MODE_INCLUDE=ONLY -DCMAKE_FIND_ROOT_PATH=$PREFIX;$BUILD_PREFIX/aarch64-conda-linux-gnu/sysroot -DCMAKE_INSTALL_PREFIX=$PREFIX -DCMAKE_INSTALL_LIBDIR=lib -DCMAKE_SYSTEM_NAME=Linux -DCMAKE_SYSTEM_PROCESSOR=aarch64

IIRC, if CMAKE_SYSTEM_PROCESSOR is set, that triggers the CMake cross-compile mode now, where I would have to refresh my knowledge because heuristic/hint logic for dependency search changes when this is used...

isuruf commented 2 years ago

@ax3l, can you check to see if d5b87b7f594509b8400742898f1507db3af2fced is sufficient alone? Your commit would definitely fix it, but I'd like to see if d5b87b7f594509b8400742898f1507db3af2fced does too

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was not passing and not merged.

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

Commits were made to this PR after the automerge label was added. For security reasons, I have disabled automerge by removing the automerge label. Please add the automerge label again (or ask a maintainer to do so) if you'd like to enable automerge again!

ax3l commented 2 years ago

@isuruf, sounds good, will do!

Looking at the aarch64/ppc64le builds with nompi, it looks like Python hints are not yet sufficient after switching CMake cross-compile mode on with this migration.

CMake Error at /home/conda/feedstock_root/build_artifacts/openpmd-api_1638472497004/_build_env/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:230 (message):
  Could NOT find Python (missing: Python_INCLUDE_DIRS Interpreter
  Development.Module)
Call Stack (most recent call first):
  /home/conda/feedstock_root/build_artifacts/openpmd-api_1638472497004/_build_env/share/cmake-3.21/Modules/FindPackageHandleStandardArgs.cmake:594 (_FPHSA_FAILURE_MESSAGE)
  /home/conda/feedstock_root/build_artifacts/openpmd-api_1638472497004/_build_env/share/cmake-3.21/Modules/FindPython.cmake:556 (find_package_handle_standard_args)
  CMakeLists.txt:352 (find_package)

For modern CMake, usually -DPython_EXECUTABLE:FILEPATH=$PYTHON is what is recommended to nail an install + version down.

isuruf commented 2 years ago

@conda-forge-admin, rerender

isuruf commented 2 years ago

See also https://github.com/conda-forge/mpich-feedstock/pull/65

ax3l commented 2 years ago

Interesting, it cannot read the file include/patchlevel.h when searching for Python: https://gitlab.kitware.com/cmake/cmake/-/blob/v3.21.4/Modules/FindPython/Support.cmake#L2917

2021-12-03T19:38:39.8978060Z CMake Error at /home/conda/feedstock_root/build_artifacts/openpmd-api_1638560049745/_build_env/share/cmake-3.21/Modules/FindPython/Support.cmake:603 (file):
2021-12-03T19:38:39.8979069Z   file STRINGS file
2021-12-03T19:38:39.8980721Z   "/home/conda/feedstock_root/build_artifacts/openpmd-api_1638560049745/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold/include/patchlevel.h"
2021-12-03T19:38:39.8981563Z   cannot be read.
2021-12-03T19:38:39.8981978Z Call Stack (most recent call first):
2021-12-03T19:38:39.8982862Z   /home/conda/feedstock_root/build_artifacts/openpmd-api_1638560049745/_build_env/share/cmake-3.21/Modules/FindPython/Support.cmake:2917 (_python_get_version)
2021-12-03T19:38:39.8984304Z   /home/conda/feedstock_root/build_artifacts/openpmd-api_1638560049745/_build_env/share/cmake-3.21/Modules/FindPython.cmake:535 (include)
2021-12-03T19:38:39.8984951Z   CMakeLists.txt:352 (find_package)

Probably it's really not there?

isuruf commented 2 years ago

Yep. It's in include/python3.7m or include/python3.8 for 3.8+

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ax3l commented 2 years ago

Thanks a lot for your help @isuruf :sparkling_heart: