conda-forge / openpmd-api-feedstock

A conda-smithy repository for openpmd-api.
BSD 3-Clause "New" or "Revised" License
1 stars 6 forks source link

Rebuild for python310 #86

Closed regro-cf-autotick-bot closed 2 years ago

regro-cf-autotick-bot commented 2 years ago

This PR has been triggered in an effort to update python310.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/1736885326, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ax3l commented 2 years ago

PyPy builds as identified by @isuruf:

the extension has the wrong name pypy37-pp73-x86_64-linux-gnu.so instead of pypy37-pp73-linux-gnu.so

Location:

Implementation:

Check:

In [2]: sysconfig.get_config_var('EXT_SUFFIX') ...:
Out[2]: '.cpython-38-x86_64-linux-gnu.so'

In [3]: sysconfig.get_config_var('SOABI')
Out[3]: 'cpython-38-x86_64-linux-gnu'


With Conda-Forge PyPy3.7:

$ pypy3.7 -c "import sysconfig; print(sysconfig.get_config_var('EXT_SUFFIX'))" .pypy37-pp73-x86_64-linux-gnu.so $ pypy3.7 -c "import sysconfig; print(sysconfig.get_config_var('SOABI'))" pypy37-pp73


hm.... this includes the architecture for `PyPy3.7`, too.
ax3l commented 2 years ago

Isuru on Gitter:

sure, but for aarch64, it should be .pypy37-pp73-linux-gnu.so it's using the build pypy's extension name instead of the host pypy's pypy3.7 didn't include the architecture for non-x86 archs it was fixed in pypy3.8

me:

Aha, got ya. So I probably hint the wrong Python interpreter to CMake then!

... yes, this should use the Python executable var: https://github.com/conda-forge/openpmd-api-feedstock/blob/master/recipe/build.sh#L64

ax3l commented 2 years ago

Still builds openpmd_api_cxx.pypy37-pp73-x86_64-linux-gnu.so...

ax3l commented 2 years ago

Isuru:

this is definitely an issue with our cross compiling setup because of setuptool>=60

X-ref: https://github.com/benfogle/crossenv/pull/86

me:

Ok, thanks! I'll merge CPython 3.10 then for now and address it later.

For naming when fixed, shouldn't this be .pypy37-pp73-aarch64-linux-gnu.so instead of .pypy37-pp73-linux-gnu.so?

Isuru:

No, pypy <3.8 had this bug which became a feature only pypy3.8 fixed it

isuruf commented 2 years ago

@ax3l, can you send a PR to add https://github.com/benfogle/crossenv/pull/86 as a patch to https://github.com/conda-forge/crossenv-feedstock ?