conda-forge / openquake.engine-feedstock

A conda-smithy repository for openquake.engine.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

Wfix #29

Closed emthompson-usgs closed 3 years ago

emthompson-usgs commented 3 years ago

Checklist

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

emthompson-usgs commented 3 years ago

@conda-forge-admin please rerender

emthompson-usgs commented 3 years ago

@ocefpaf Would you be able to help figure out what to do about this package? Please ignore the embarrassing mess of things I tried in this pull request. Also tagging @mhearne-usgs since he would probably like to follow this conversation.

The main issue is that the noarch version of this package was not able to install in Windows (details in issue #27) so I wanted to modify the recipe to use build.sh and bld.bat scripts for the different architectures, hoping that I could eventually resolve the Windows issue with the bld.bat script. It is odd that the package installs via pip in Windows, and this conda package is built from pypi package.

The current status is:

Any guidance you have would be much appreciated!

ocefpaf commented 3 years ago

@ocefpaf Would you be able to help figure out what to do about this package? Please ignore the embarrassing mess of things I tried in this pull request. Also tagging @mhearne-usgs since he would probably like to follow this conversation.

I can try to look into this PR tomorrow but I just tried this on a Winddows machine:

conda create --name TEST openquake.engine

with this .condarc:

show_channel_urls: true
channel_priority: strict
channels:
  - conda-forge
  - defaults

Everything worked.

The main issue is that the noarch version of this package was not able to install in Windows (details in issue #27) so I wanted to modify the recipe to use build.sh and bld.bat scripts for the different architectures, hoping that I could eventually resolve the Windows issue with the bld.bat script. It is odd that the package installs via pip in Windows, and this conda package is built from pypi package.

I'm not sure that is the issue. noarch packages are is installable using the new env and the condarc above.

The current status is:

  • Linux and OSX builds are not able to solve for the dependencies (OSX did solve at one point, but I relaxed the dep versions hoping it would resolve the linux deps and that ended up breaking the OSX deps)
  • Windows builds for python 3.6 and 3.7 give UnboundLocalError: local variable 'out' error, and there's something about unicode before that but I am not able to make sense of it.
  • Windows builds for python 3.8 don't have the UnboundLocalError but are not able to resolve dependencies.

Any guidance you have would be much appreciated!

I'll send an updating PR and test all platform in a moment.