search

conda-forge / or-tools-feedstock

A conda-smithy repository for or-tools.
BSD 3-Clause "New" or "Revised" License
3 stars 8 forks source link

Don't repackage library bits for ortools-python; split off binaries into separate output #43

Closed h-vetinari closed 1 year ago

h-vetinari commented 1 year ago

This should have been done already in the context of f5e879db5df0b662c2bb1045d4833341bf25ab22

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 1 year ago

@conda-forge/or-tools @Mizux @xhochy PTAL

This solves a long-standing problem, where we rebuilt the exact same libortools once for C++ and once for python. Now the latter depends on the former, rather than vendoring it.

It also splits of the binaries from the library in the same way that thrift-cpp already does it. This is already built in a way that will be easy to extend in #36, because we'll need another output ortools-samples to test the scip integration without packaging a lot of things that aren't needed for the normal case.

First commit is best viewed with whitespace changes ignored.