Closed h-vetinari closed 5 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@conda-forge-admin, please rerender
@conda-forge/help-python-c
Hey everyone; I was wondering if someone can help me debug this recipe. I manage to build this locally with VS2017, but on the azure machines it crashes with:
[...]
running build_ext
CMake Error at CMakeLists.txt:5 (project):
Failed to run MSBuild command:
MSBuild.exe
to get the value of VCTargetsPath:
Microsoft (R) Build Engine version 4.8.3761.0
[Microsoft .NET Framework, version 4.0.30319.42000]
Copyright (C) Microsoft Corporation. All rights reserved.
Any pointers or help very much appreciated. :)
Use NMake Makefiles
as the CMake generator. This should fix the mentioned issue.
Thanks for the tip and the quick response @xochy, that did indeed solve it (after a few tries).
This is out of WIP now. I'll leave this open for a few days for you to review @dougalsutherland, but plan to merge eventually. I tried to keep the patches absolutely minimal for passing the CI.
However, since cmake & the compilers are not a runtime dependency, it might make sense to add a warning to codegen
that the respective dependencies can be installed with conda install -c conda-forge cmake compilers
Thanks for this @h-vetinari! Sorry I wasn't responding, was in the process of a complicated move and then vacation. :)
@dougalsutherland: Thanks for this @h-vetinari! Sorry I wasn't responding, was in the process of a complicated move and then vacation. :)
No worries! Once you'll have some more time, feel free to join us trying to unblock the windows builds in #12. :)
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)closes #1
~Also added
cmake
to runtime dependencies for the codegen-interface,~ the tests of which are now enabled as well.Builds locally for me on windows, but labeling this as WIP until linux/macos comes through as well...