search

conda-forge / osqp-feedstock

A conda-smithy repository for osqp.
BSD 3-Clause "New" or "Revised" License
0 stars 13 forks source link

osqp v0.6.1 #12

Closed h-vetinari closed 5 years ago

h-vetinari commented 5 years ago

Checklist

Seems there was a very quick bugfix release of 0.6.1 after 0.6.0.

Closes #11 (if everything runs through)

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

bstellato commented 5 years ago

@conda-forge-admin, please rerender

bstellato commented 5 years ago

@h-vetinari I have tried to push to the branch 0.6.1 of your fork but I do not have permissions. Is there any change I need to be able to push?

h-vetinari commented 5 years ago

@bstellato Hey, I thought you'd have the rights as well, to be honest. In any case, you can push to the branches of regro-cf-autotick-bot (like I did in #11).

I'll try to add you as a collaborator to my fork, then you should definitely have the push rights.

bstellato commented 5 years ago

Ok Thanks! It worked.

bstellato commented 5 years ago

@conda-forge/help-python-c does anyone know why the windows build is always failing? I am not sure why it is always trying to link against the debug version of Python. It would be great to have 0.6.1 on conda-forge so that we can change the main website documentation and redirect all the downloads to the conda-forge channel.

bstellato commented 5 years ago

@conda-forge-admin, please rerender

bstellato commented 5 years ago

Now the "debug" issue should be fixed. However, it still fails with codegen on windows here. It is very weird. It says that there is an unmatched parenthesis but every other platform is fine. Can it be related to NMake on windows? Is there a reason why we are not just sticking with CMake on windows?

h-vetinari commented 5 years ago

@bstellato Cool that you fixed the issue with the debug-build! Unmatched parentheses sounds more tractable I guess...? Could it be that MVSC is less permissive or has a bug?

h-vetinari commented 5 years ago

Can it be related to NMake on windows? Is there a reason why we are not just sticking with CMake on windows?

To be honest, I don't know. I only changed to NMake at the advice of @xhochy, because I was running into troubles when trying to build for windows. But I guess there's no reason we couldn't try to go back to CMake.

bstellato commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you, but it looks like there was nothing to do.

h-vetinari commented 5 years ago

@conda-forge-admin, please rerender

h-vetinari commented 5 years ago

@conda-forge/core Hey, we just added ppc64le support in another PR, and after merging master here, a rerender removes those CI jobs again. Seems like a conda smithy bug?

(also, if someone has the time to have a look at our windows builds, which we can't get to run with neither NMake nor CMake).

isuruf commented 5 years ago

You have a bad merge. See https://github.com/conda-forge/osqp-feedstock/blob/master/conda-forge.yml#L6-L9

h-vetinari commented 5 years ago

@conda-forge-admin, please rerender

h-vetinari commented 5 years ago

@isuruf Thanks a lot for the quick response! :)

If you have time, it would help us a lot if you could have a look at our windows jobs - we haven't been able to debug the MVSC / NMake / CMake interactions.

isuruf commented 5 years ago

In azure, CMake with Visual Studio generator doesn't work. You need to use NMake Makefiles or Ninja generator.

h-vetinari commented 5 years ago

@isuruf Thanks, we know that (but admittedly didn't know why exactly), however we also run into errors with NMake: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=71417&view=logs&jobId=171a126d-c574-5c8c-1269-ff3b989e923d

h-vetinari commented 5 years ago

@isuruf I reverted back to reinstate NMake - we had experimented with going back to CMake after being puzzled that MVSC complains about a mismatched parenthesis (for code that runs on all other platforms; when compiled with NMake):

d:\bld\osqp_1568619494774\test_tmp\code2\include\glob_opts.h(110): fatal error C1012: unmatched parenthesis: missing ')'
h-vetinari commented 5 years ago

Superseded by #17 / #18