search

conda-forge / osqp-feedstock

A conda-smithy repository for osqp.
BSD 3-Clause "New" or "Revised" License
0 stars 13 forks source link

ARM OSX Migrator #26

Closed regro-cf-autotick-bot closed 3 years ago

regro-cf-autotick-bot commented 3 years ago

This feedstock is being rebuilt as part of the ARM OSX migration.

Feel free to merge the PR if CI is all green, but please don't close it without reaching out the the ARM OSX team first at @conda-forge/help-osx-arm64.

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/455748007, please use this URL for debugging

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

h-vetinari commented 3 years ago

I've been battling with unresolvable test errors across all builds in the osqp-feedstock (#24), so it's very surprising that the ARM portion passes here. And indeed, based on the logs, it looks like the test suite was not run?! @conda-forge/help-osx-arm64

erykoff commented 3 years ago

@h-vetinari It is true that the arm64 builds do not run the tests, because we can't run tests for cross-compiled packages (because the binaries are for the wrong architecture). We do run tests externally with a cron job and monitor these for issues and then fix these when they come up. Details here: https://conda-forge.org/blog/posts/2020-10-29-macos-arm64/

Meanwhile, the issue with the failing tests here seems to be that the latest version of scipy has deprecated some of the calls that are used in this package. (And presumably this happened since the last time we ran the CI tests...) So I think we either need to set a maximum version of scipy, or fix/update the package to not use the deprecated calls.

isuruf commented 3 years ago

I don't think the failures are about the scipy version. Those re just warnings.

github-actions[bot] commented 3 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!