search

conda-forge / pandas-feedstock

A conda-smithy repository for pandas.
BSD 3-Clause "New" or "Revised" License
8 stars 36 forks source link

Rebuild version 1.5.3 for python 3.12 #185

Open admirito opened 1 year ago

admirito commented 1 year ago

Checklist

NOTE: This PR is not based on the main branch but is based on the latest commit in the main branch before transitioning to version 2, which is 66ac579.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

admirito commented 1 year ago

Thank you, @ocefpaf, for creating the v1.5.x branch. This allows us to rebuild the latest 1.x version, which is 1.5.3, compatible with Python 3.12. However, there is a minor issue. The v1.5.x target branch is currently based on the latest main branch, which includes all the updates for the 2.1.x version. Is it possible to reset the branch, basing it on the commit 66ac579, which is the latest one before transitioning to version 2? This way, we can merge this PR without encountering any conflicts.

lithomas1 commented 1 year ago

This is a very old version of pandas - Is there a reason you are trying to port it to Python 3.12?

Pandas 2.1 is the first version with Python 3.12 support, and a lot of things have changed since pandas 1.5.3, one major one being the build system. So, unfortunately, I don't think this would be possible without a large amount of code changes.

admirito commented 1 year ago

This is a very old version of pandas - Is there a reason you are trying to port it to Python 3.12?

Pandas 2.1 is the first version with Python 3.12 support, and a lot of things have changed since pandas 1.5.3, one major one being the build system. So, unfortunately, I don't think this would be possible without a large amount of code changes.

My intention in creating the v1.5.x branch was to provide a solution for users who are currently using an older version of pandas and need compatibility with Python 3.12. By building a Python 3.12-compatible version of the latest 1.x series, users can gradually update their applications without facing immediate compatibility issues.

I have already submitted another PR that reverts the changes back to commit 66ac579 in a single commit, ensuring that the branch is based on the last 1.x version before transitioning to version 2. If the build fails or this approach adds too much maintenance burden, I completely understand and am willing to close both PRs.

admirito commented 1 year ago

The build for that branch for python 3.12 has also failed. If there is anything I can do to help with the build, I will gladly assist. However, if you believe it is not possible to build for the old version, we can close this PR and potentially remove the v1.5.x branch as well.