Explicitly depend on qt-main; build against qt-main on osx-arm64

conda-forge / pcl-feedstock

A conda-smithy repository for pcl.

BSD 3-Clause "New" or "Revised" License

3 stars 15 forks source link

Closed Tobias-Fischer closed 2 years ago

Tobias-Fischer commented 2 years ago

Currently it is implicitly pulled in via vtk.

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 2 years ago

Tobias-Fischer commented 2 years ago

Will wait till https://github.com/conda-forge/vtk-feedstock/pull/251 is merged which enables support for vtk+qt on osx-arm64.

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Tobias-Fischer commented 2 years ago

Looking through the build logs, I found that python is pulled in. I also explicitly depend on it now.

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 2 years ago

@conda-forge-admin, please rerender

Tobias-Fischer commented 2 years ago

This is ready for review @hobu @chambbj

Tobias-Fischer commented 2 years ago

https://github.com/conda-forge/vtk-feedstock/pull/251 has been merged - triggering another build just to make sure all is still good.

Tobias-Fischer commented 2 years ago

Still looks all good @conda-forge/pcl