conda-forge / pcl-feedstock

A conda-smithy repository for pcl.
BSD 3-Clause "New" or "Revised" License
3 stars 15 forks source link

Rebuild for libboost 1.86 #71

Closed regro-cf-autotick-bot closed 1 month ago

regro-cf-autotick-bot commented 1 month ago

This PR has been triggered in an effort to update libboost186.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/10439499431 - please use this URL for debugging.

conda-forge-webservices[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

traversaro commented 1 month ago

All errors are:

[ 35%] Building CXX object visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o
/home/conda/feedstock_root/build_artifacts/pcl_1723976756675/work/visualization/src/pcl_visualizer.cpp: In member function 'std::string pcl::visualization::PCLVisualizer::getUniqueCameraFile(int, char**)':
/home/conda/feedstock_root/build_artifacts/pcl_1723976756675/work/visualization/src/pcl_visualizer.cpp:4595:24: error: cannot convert 'unsigned int [5]' to 'unsigned char (&)[20]'
 4595 |       sha1.get_digest (digest);
      |                        ^~~~~~
      |                        |
      |                        unsigned int [5]
In file included from /home/conda/feedstock_root/build_artifacts/pcl_1723976756675/work/visualization/src/pcl_visualizer.cpp:102:
/home/conda/feedstock_root/build_artifacts/pcl_1723976756675/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placeho/include/boost/uuid/detail/sha1.hpp:179:43: note:   initializing argument 1 of 'void boost::uuids::detail::sha1::get_digest(unsigned char (&)[20])'
  179 | inline void sha1::get_digest(digest_type& digest)
      |                              ~~~~~~~~~~~~~^~~~~~
make[2]: *** [visualization/CMakeFiles/pcl_visualization.dir/build.make:118: visualization/CMakeFiles/pcl_visualization.dir/src/pcl_visualizer.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1204: visualization/CMakeFiles/pcl_visualization.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
traversaro commented 1 month ago

Upstream PR https://github.com/PointCloudLibrary/pcl/pull/6105 mention Boost 1.86, but I do not see any change directly related.

Tobias-Fischer commented 1 month ago

Do you think this could be related? https://github.com/conda-forge/robotraconteur-feedstock/pull/27/commits/799f3a3bba97281dd988cc1c43d9b7bf0bdebff7

traversaro commented 1 month ago

Do you think this could be related? conda-forge/robotraconteur-feedstock@799f3a3

I am not sure, but if https://github.com/PointCloudLibrary/pcl/pull/6105 fixes the problem I would use that as it is the upstream fix.

Tobias-Fischer commented 1 month ago

See #72