conda-forge / pdal-feedstock

A conda-smithy repository for pdal.
BSD 3-Clause "New" or "Revised" License
3 stars 19 forks source link

Attempt to split into multiple packages #214

Closed hobu closed 8 months ago

hobu commented 1 year ago

For the upcoming PDAL 2.6.0, we have added the ability to conveniently build -DSTANDALONE=ON plugins that have external library dependencies. This should allow us to split the conda package into something like this:

It's not quite working and of course points to the unreleased PDAL 2.6.0 branch but I want to make sure it can work before releasing 2.6.0.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

hobu commented 11 months ago

@ocefpaf For the not-yet-released PDAL 2.6.0, we am planning on splitting pdal package into a number of subpackages including libpdal. This is to reduce our sensitivity to various plugins requiring rerendering and to cut out some conflicts that seem to be arising on windows.

What considerations should we take before we merge this PR (after PDAL 2.6.0 is released, of course)?

ocefpaf commented 11 months ago

Multiple outputs can be complex but at a first glance everything looks good here. I'm not the best person to say b/c we need to know how the downstream packages and users are using pdal. for example, someone that expects to just conda install pdal seems to be covered. The ones that may want pdal-* will need docs/warnings.

The most complex one are packaging that are building using pdal but from now on would be OK with libpdal only. Those will require a pin to ensure they'll get the right combo of pdal/libpdal. (Image building with one version of libpdal but, if we forget to pin things correctly, install it with an older pdal.)

hobu commented 11 months ago

A couple more points to add.

ocefpaf commented 11 months ago
  • How should we update pins to protect this from falling apart 😄 ?

Let's say that from now on you only want folks building against pdal 2.6.0, unless they explicitly require an older version, you should mimic gdal/libgdal pins in: https://github.com/conda-forge/conda-forge-pinning-feedstock/blob/main/recipe/conda_build_config.yaml

PS: Hey @isuruf I know you are super busy lately with the Windows arm stuff but if you find some spare time do you mind taking a look at this PR?

isuruf commented 11 months ago

Add

conda_build:
  error_overlinking: true

to conda-forge.yml and this build would error. You should fix the dependencies so that the build passes again.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

For recipe:

conda-forge-webservices[bot] commented 11 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 10 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-webservices[bot] commented 8 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.