Continuation of package splitting

conda-forge / pdal-feedstock

A conda-smithy repository for pdal.

BSD 3-Clause "New" or "Revised" License

3 stars 19 forks source link

Continuation of package splitting #247

Open hobu opened 4 months ago

hobu commented 4 months ago

Checklist

[ ] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 2 months ago

@hobu @chambbj , this is ready for a review. Current plan is to

Create a libpdal-feedstock with the recipe in the PR by submitting to staged-recipes
Build python-pdal in python-pdal-feedstock using libpdal
Make this feedstock create a pdal==2.7.1 meta-package that installs libpdal-all and python-pdal.

Let me know what you think

hobu commented 2 months ago

I will upstream all of these patches to PDAL's 2.7-maintenance branch and they will be available when 2.7.2 is released.

hobu commented 2 months ago

What will happen to pdal-feedstock after implementing this plan? Will it be removed?

isuruf commented 2 months ago

What will happen to pdal-feedstock after implementing this plan? Will it be removed?

No, it will produce a pdal meta-package that installs libpdal-all and python-pdal

isuruf commented 2 months ago

If libgdal is going to be further split up to libgdal-core + plugins, we might have to change the naming here.

hobu commented 2 months ago

If libgdal is going to be further split up to libgdal-core + plugins, we might have to change the naming here.

Indeed, we want to follow whatever GDAL does.

I've looked this over and I don't have any complaints. I have merged up your patches to the PDAL 2.7 branch and they will be available when I release PDAL 2.7.2 middle of next week.

I'm 👍 to merge whenever you are ready.