search

conda-forge / perl-feedstock

A conda-smithy repository for perl.
BSD 3-Clause "New" or "Revised" License
3 stars 32 forks source link

Replace $BUILD_PREFIX in generated config files #33

Closed abretaud closed 5 years ago

abretaud commented 5 years ago

Checklist

Here's an attempt at fixing #29 The recipe builds successfully on my laptop, but i haven't yet tested if the change is enough to fix the problem when building other perl modules I'm not an expert of this, so I hope this won't break anything else...

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

abretaud commented 5 years ago

@conda-forge-admin, please rerender

abretaud commented 5 years ago

Tested and... it fails...

abretaud commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

abretaud commented 5 years ago

ping @conda-forge/core No idea why rerender failed

abretaud commented 5 years ago

So with the latest change, instead of replacing the hard-coded paths by other hard-coded paths, I made the perl code look at the env var to guess the correct paths. Not using PREFIX or BUILD_PREFIX as we we don't know if we're building a conda package of just using in normal life.

I tested it by installing locally this perl modified package + perl-extutils-makemaker into a clean conda env, then trying to build perl-statistics-caseresampling package with perl Makefile.PL INSTALLDIRS=site && make. And this time it worked.

I don't know if there might be other cases where it won't work, but I think it's already better

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

abretaud commented 5 years ago

I think the appveyor is red only because of network problem

abretaud commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

bgruening commented 5 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to re-render for you but ran into some issues, please ping conda-forge/core for further assistance.

abretaud commented 5 years ago

ICYMI ping @jakirkham @mingwandroid @msarahan

conda-forge-linter commented 5 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

abretaud commented 5 years ago

Changes done! If updating to 5.26.3, does it mean all perl-* packages will need to be rebuilt?

druvus commented 5 years ago

The perl pinning is set to max_pin: x.x.x so maybe better to fix 5.26.2 before updating?

abretaud commented 5 years ago

Ok, yep I prefer fixing 5.26.2 first too

abretaud commented 5 years ago

Any chance to get this merged soon? It's blocking a few things in my todo list

abretaud commented 5 years ago

Super cool, thanks @bgruening!

abretaud commented 5 years ago

Ah. There's a little problem with my patch (https://circleci.com/gh/bioconda/bioconda-recipes/51272)... I'm working on a fix