conda-forge / perl-feedstock

A conda-smithy repository for perl.
BSD 3-Clause "New" or "Revised" License
3 stars 31 forks source link

perl 5.32.0 #40

Closed mrakitin closed 4 years ago

mrakitin commented 4 years ago

Checklist

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

Documentation on acceptable licenses can be found here.

mrakitin commented 4 years ago

@conda-forge-admin, please rerender

mrakitin commented 4 years ago

I bumped the build number to 1000. I heard something it will have some effect on compilers. Or should it be reset to actual 0?

mrakitin commented 4 years ago

Also, regarding the license, the Copying file which comes in https://www.cpan.org/src/5.0/perl-5.32.0.tar.gz is GNU-GPL. I guess the license here should be updated.

Regarding the Windows builds, this is the latest one at the moment: http://strawberryperl.com/download/5.30.2.1/strawberry-perl-5.30.2.1-64bit.msi. Worth skipping for now?

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

isuruf commented 4 years ago

@conda-forge/perl, this is ready now

isuruf commented 4 years ago

@conda-forge/core, this is ready for review. I'm adding myself as a maintainer.

beckermr commented 4 years ago

Do we want to tell the bioconda folks?

isuruf commented 4 years ago

cc @conda-forge/bioconda-recipes

isuruf commented 4 years ago

ping on this

mrakitin commented 4 years ago

Thanks @isuruf for taking care of this PR.