Closed mbargull closed 4 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
I'm going ahead and merge this because it's hindering bulk work over at Bioconda.
Yes, sure thing. On AD I have a WIP change that just removes the two problematic lines (and I think a leak of build system info into the package). Hopefully I can find the time to propose it if you think that better?
(if we want to get towards better reproducibility then I think removing the lines works in that direction)
@mingwandroid, thanks for looking into it! Right, I also noticed that the content is build system-specific and something we don't actually want to include.
I just made the bare minimum change because I'm not aware of any consequences of additional changes ;).
If it doesn't cause any problems when we remove cf_email
and perladmin
, then sure, go for it. If something might need those definitions, we should set them to some static values, I think.
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)Previously we had
now it is
. Which means the osx build is currently broken.
It would be good to add a test for this, but I don't know Perl, so can't easily help with that.