conda-forge / perl-feedstock

A conda-smithy repository for perl.
BSD 3-Clause "New" or "Revised" License
3 stars 31 forks source link

fix sed @-escaping command #43

Closed mbargull closed 4 years ago

mbargull commented 4 years ago

Checklist

Previously we had

lib/5.26.2/x86_64-linux-thread-multi/Config_heavy.pl:249:cf_email='conda\@5b5b05c2e5c2.(none)'
lib/5.26.2/x86_64-linux-thread-multi/Config_heavy.pl:1178:perladmin='conda\@5b5b05c2e5c2.(none)'
lib/5.26.2/darwin-thread-multi-2level/Config_heavy.pl:251:cf_email='vsts\@mac-616.local'
lib/5.26.2/darwin-thread-multi-2level/Config_heavy.pl:1182:perladmin='vsts\@mac-616.local'

now it is

lib/5.30.3/x86_64-linux-thread-multi/Config_heavy.pl:248:cf_email='conda\@f52d8439f892.(none)'
lib/5.30.3/x86_64-linux-thread-multi/Config_heavy.pl:1173:perladmin='conda\@f52d8439f892.(none)'
lib/5.30.3/darwin-thread-multi-2level/Config_heavy.pl:250:cf_email='root@mac-1610.local'
lib/5.30.3/darwin-thread-multi-2level/Config_heavy.pl:1177:perladmin='root@mac-1610.local'

. Which means the osx build is currently broken.

It would be good to add a test for this, but I don't know Perl, so can't easily help with that.

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mbargull commented 4 years ago

I'm going ahead and merge this because it's hindering bulk work over at Bioconda.

mingwandroid commented 4 years ago

Yes, sure thing. On AD I have a WIP change that just removes the two problematic lines (and I think a leak of build system info into the package). Hopefully I can find the time to propose it if you think that better?

mingwandroid commented 4 years ago

(if we want to get towards better reproducibility then I think removing the lines works in that direction)

mbargull commented 4 years ago

@mingwandroid, thanks for looking into it! Right, I also noticed that the content is build system-specific and something we don't actually want to include. I just made the bare minimum change because I'm not aware of any consequences of additional changes ;). If it doesn't cause any problems when we remove cf_email and perladmin, then sure, go for it. If something might need those definitions, we should set them to some static values, I think.