Fix lddlflags again - Githubissues

conda-forge / perl-feedstock

A conda-smithy repository for perl.

BSD 3-Clause "New" or "Revised" License

3 stars 32 forks source link

Fix lddlflags again #63

Closed isuruf closed 9 months ago

isuruf commented 1 year ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

fixes gh-59

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mbargull commented 9 months ago

@conda-forge-admin, please rerender

mbargull commented 9 months ago

It's apparent that lddlflags is just as ldflags something to be used when invoking the linker through the compiler. Hence, changing lddlflags to be usable by the linker directly is not the right thing to do.

The issue from https://github.com/conda-forge/perl-feedstock/issues/59#issuecomment-1623967103 can be reproduced on Linux too. Removing the LD environment variable (set by our compiler/linker activation packages) fixes the issue.

I'll add a patch to remove the LD usage from ExtUtils::CBuilder. I'm somewhat perplexed that the ExtUtils::CBuilder is using LD directly and wonder if/why that issue hasn't come up elsewhere...

mbargull commented 9 months ago

I'm somewhat perplexed that the ExtUtils::CBuilder is using LD directly and wonder if/why that issue hasn't come up elsewhere...

There is https://github.com/Perl/perl5/issues/13531 but I only skimmed over that; TL;DR...

mbargull commented 9 months ago

@isuruf, I've just added the automerge label. I just wanted to get this in prior to the libxcrypt rebuild. Let me know if this looks good to you or whether we need further changes on this.

github-actions[bot] commented 9 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
travis: passed
azure: passed

Thus the PR was passing and merged! Have a great day!