add complex variant - Githubissues

conda-forge / petsc4py-feedstock

A conda-smithy repository for petsc4py.

BSD 3-Clause "New" or "Revised" License

0 stars 15 forks source link

add complex variant #40

Closed ltalirz closed 3 years ago

ltalirz commented 3 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The recipe must have a build/number section.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

ltalirz commented 3 years ago

@conda-forge-admin, please rerender

ltalirz commented 3 years ago

Of course one side effect of this is that it doubles the number of builds to 50 ;-)

Edit: almost doubles; 25 => 41. I don't see a way around this though.

dalcinl commented 3 years ago

Of course one side effect of this is that it doubles the number of builds to 50 ;-)

Edit: almost doubles; 25 => 41. I don't see a way around this though.

Let it be, let it be...

There is no way around it, I think.

ltalirz commented 3 years ago

@dalcinl CI passes.

The tests currently just import the package. Not sure whether one should add something more there to make sure it actually works