search

conda-forge / petsc4py-feedstock

A conda-smithy repository for petsc4py.
BSD 3-Clause "New" or "Revised" License
0 stars 15 forks source link

Build with NumPy 1.8 and require NumPy >= 1.8 at runtime #7

Closed dalcinl closed 6 years ago

conda-forge-linter commented 6 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

dalcinl commented 6 years ago

Attempt to fix issue #6 reported by @jedbrown.

dalcinl commented 6 years ago

@minrk I think I got it right, but please double check. After inspecting the build logs, the build is done with NumPy 1.7(py2)/1.8(py3), but tests ran with the newest NumPy available in the conda-forge channel.

dalcinl commented 6 years ago

@minrk the NumPy 1.7.2 conda-forge osx-64 binaries are labeled as broken, so the Travis-CI builds for Python 2.7 picked the numpy package from the default channel. What should I do? Maybe build with numpy 1.8.* and runtime require numpy >=1.8 in all platforms and Python versions?

dalcinl commented 6 years ago

I took a decision: build with numpy 1.8 and require numpy >= 1.8.