conda-forge / pillow-feedstock

A conda-smithy repository for pillow.
BSD 3-Clause "New" or "Revised" License
2 stars 30 forks source link

Remove test image flaged by AV software #114

Closed johnbradley closed 2 years ago

johnbradley commented 2 years ago

Remove crash-81154a65438ba5aaeca73fd502fa4850fbde60f8.tif test image. This is a valid test file but the antivirus software flagged it as "potential malware". The associated test should just skip since the input file will no longer exist. The test image is still accessible from: https://github.com/python-pillow/pillow-depends/tree/main/test_images

Increment the build number.

Checklist

Related to Issue #113

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

johnbradley commented 2 years ago

The tests are failing on the missing crash-81154a65438ba5aaeca73fd502fa4850fbde60f8.tif test file: https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=474402&view=logs&j=d0d954b5-f111-5dc4-4d76-03b6c9d0cf7e&t=841356e0-85bb-57d8-dbbc-852e683d1642&l=4063

I will look into this error in a few days when time permits.

h-vetinari commented 2 years ago

It's completely expected that the tests that require the image you removed will fail. Just add them to the tests_to_skip variable that already exists in the recipe and you should be fine.

h-vetinari commented 2 years ago

Thanks for this! :)

github-actions[bot] commented 2 years ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!