search

conda-forge / pillow-feedstock

A conda-smithy repository for pillow.
BSD 3-Clause "New" or "Revised" License
2 stars 30 forks source link

Remove pinning of vs2015_runtime #13

Closed jakirkham closed 8 years ago

jakirkham commented 8 years ago

DO NOT MERGE YET! THIS WILL BREAK WINDOWS PYTHON 3.5 BUILDS.

Just getting this one ready. We ultimately do want to merge this, but not until issue ( https://github.com/conda-forge/staged-recipes/issues/666 ) is resolved.

conda-forge-linter commented 8 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

pelson commented 8 years ago

I have just restarted AppVeyor, and believe this will now pass. Please merge when it goes green. :+1:

pelson commented 8 years ago

Maybe it wont go green though because of py34 x86: https://github.com/conda-forge/pillow-feedstock/issues/9

patricksnape commented 8 years ago

https://github.com/conda-forge/staged-recipes/issues/666 Should no longer be an issue as I believe @msarahan removed the broken runtime. I haven't look at #9 yet but it does seem frustrating.

jakirkham commented 8 years ago

Correct, this should be fine.

jakirkham commented 8 years ago

Yeah, issue ( https://github.com/conda-forge/pillow-feedstock/issues/9 ) already existed in master so every PR will hit that problem. Not sure why it exists now. When someone has time it might be worth digging into history here and at staged-recipes as I believe this was passing at some point.