search

conda-forge / pillow-feedstock

A conda-smithy repository for pillow.
BSD 3-Clause "New" or "Revised" License
2 stars 29 forks source link

pillow v7.0.0 #71

Closed regro-cf-autotick-bot closed 4 years ago

regro-cf-autotick-bot commented 4 years ago

It is very likely that the current package version for this feedstock is out of date. Notes for merging this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version. Checklist before merging this PR:
    • [x] Dependencies have been updated if changed
    • [x] Tests have passed
    • [x] Updated license if changed and license_file is packaged

Note that the bot will stop issuing PRs if more than 3 Version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR

If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one.

This PR was created by the cf-regro-autotick-bot. The cf-regro-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. If you would like a local version of this bot, you might consider using rever. Rever is a tool for automating software releases and forms the backbone of the bot's conda-forge PRing capability. Rever is both conda (conda install -c conda-forge rever) and pip (pip install re-ver) installable. Finally, feel free to drop us a line if there are any issues! This PR was generated by https://circleci.com/gh/regro/circle_worker/13311, please use this URL for debugging

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

kmilos commented 4 years ago

This update will also suffer from #69, is it possible to pin to libtiff 4.0.10 (for Windows at least)?

patricksnape commented 4 years ago

If this is merged (https://github.com/conda-forge/libtiff-feedstock/pull/49) then surely we don't need to do the pinning?

hmaarrfk commented 4 years ago

merged ;)

hmaarrfk commented 4 years ago

The thing is, if you go against the pinnings, with something older, you won't be able to install other software.

So anything that tries to install libtiff + opencv for example, will not be able to install PIL 7.0.0

patricksnape commented 4 years ago

So we should forgo the pinnings for now (since we don't want to go against the conda-forge pinnings) and try work on fixing this either with a patched version of pillow or libtiff?

Aka LGTM?

patricksnape commented 4 years ago

Given that it seems there will be a fix for libtiff as described here:

https://github.com/python-pillow/Pillow/issues/4237#issuecomment-570757948

I am inclined to merge this today if noone has any reservations

hmaarrfk commented 4 years ago

@patricksnape could you merge https://github.com/conda-forge/pillow-feedstock/pull/72 instead? it builds libtiff 4.0 as well for windows.

patricksnape commented 4 years ago

Closing in favor of https://github.com/conda-forge/pillow-feedstock/pull/72