search

conda-forge / pinocchio-feedstock

A conda-smithy repository for pinocchio.
BSD 3-Clause "New" or "Revised" License
12 stars 10 forks source link

Revert "[bot-automerge] pinocchio v2.9.1" #62

Closed jcarpent closed 3 years ago

jcarpent commented 3 years ago

Reverts conda-forge/pinocchio-feedstock#61

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice.

It appears you are making a pull request from a branch in your feedstock and not a fork. This procedure will generate a separate build for each push to the branch and is thus not allowed. See our documentation for more details.

Please close this pull request and remake it from a fork of this feedstock.

Have a great day!

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

I am afraid that even after this PR conda will install install pinocchio 2.9.1 as it is the newest version. I think the only way of avoiding that is either to eventually release a version with an higher version number, or mark 2.9.1 as broken in https://github.com/conda-forge/admin-requests#mark-packages-as-broken-on-conda-forge .

wolfv commented 3 years ago

If you want to remove the builds from anaconda.org you'll have to send a pr to the repodata patches feedstock iirc

proyan commented 3 years ago

@wolfv Thanks for your review. The documentation at https://conda-forge.org/docs/maintainer/updating_pkgs.html#maint-fix-broken-packages mentions that

"Open a new PR [for marking a package as broken in @conda-forge/admin-requests]. Once merged, a bot will label all listed files as broken, thus effectively removing them from the channel."

and

If the only issue is in the package metadata, we can directly patch it using the repo data patches feedstock. Please make a PR there to add a patch. In order to ensure future versions have the required changes, you also need to change the recipe to reflect the metadata changes.

Could you please confirm that since we want to fix not just the metadata, but remove the contents of the pre-release as well, marking the package as broken should be enough?

proyan commented 3 years ago

Thanks @traversaro for the info about broken packages.

jcarpent commented 3 years ago

If you want to remove the builds from anaconda.org you'll have to send a pr to the repodata patches feedstock iirc

@wolfv Could you elaborate a bit more on the way to proceed exactly? @proyan Could you handle it?

Thanks a lot.