Update to 24.1.2, use pip source to install itself.

conda-forge / pip-feedstock

A conda-smithy repository for pip.

BSD 3-Clause "New" or "Revised" License

2 stars 21 forks source link

Update to 24.1.2, use pip source to install itself. #121

Closed jjhelmus closed 3 months ago

jjhelmus commented 4 months ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

Changes:

Update to version 24.1.2
Bump minimum Python version to 3.8. Python 3.7 support was removed in version 24.1.
Use the pip source to install itself. Note that setup.py was removed in version 24.1.
Remove the run requirements on setuptools and wheel. They are only needed to build the package not at runtime.

conda-forge-webservices[bot] commented 4 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jjhelmus commented 4 months ago

@conda-forge-admin, please rerender

jjhelmus commented 4 months ago

Another option for building pip is to use the wheel published on PyPI. This would remove the host requirement on setuptools and wheel which breaks a dependency cycle.

I have a branch on my fork that implements this if there is interest.

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 3 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

linter: passed
azure: passed

Thus the PR was passing and merged! Have a great day!

beckermr commented 3 months ago

@conda-forge/pip @conda-forge/core The removal of setuptools and wheel is breaking expectations people have had for what they get in the env when they install pip. Do we need to add them back?

jakirkham commented 3 months ago

The change was intentional in the bullet points above:

Remove the run requirements on setuptools and wheel. They are only needed to build the package not at runtime.

That said, no strong feelings if folks would like to add them back

jakirkham commented 3 months ago

Let's move further discussion of this to the open issue for easier tracking: https://github.com/conda-forge/pip-feedstock/issues/124

beckermr commented 3 months ago

Yep. I see that the change was intentional.

I am looking for further discussion. Do we want to take the pure path here or go more "batteries included"?

AFAIK, we have shipped setuptools+wheel as run deps with pip for ~8 years now (https://github.com/conda-forge/pip-feedstock/commit/5f1aff626e8714969fcb83e5431ab07639b47ff0) since this feedstock was created.

Given how low this package sits in the typical dev stack, the removal of these deps is definitely non-trivial.

jakirkham commented 3 months ago

Could we please move this to the open issue ( https://github.com/conda-forge/pip-feedstock/issues/124 )?