Update build flags in pip script

conda-forge / plasticparcels-feedstock

A conda-smithy repository for plasticparcels.

BSD 3-Clause "New" or "Revised" License

0 stars 2 forks source link

Update build flags in pip script #5

Closed VeckoTheGecko closed 1 month ago

VeckoTheGecko commented 1 month ago

https://github.com/OceanParcels/plasticparcels/issues/51#issuecomment-2381095887

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged) * [ ] Reset the build number to 0 (if the version changed)
[ ] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

VeckoTheGecko commented 1 month ago

Addresses https://github.com/OceanParcels/plasticparcels/issues/51#issuecomment-2381095887

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe/meta.yaml:

No valid build backend found for Python recipe for package plasticparcels using pip. Python recipes using pip need to explicitly specify a build backend in the host section. If your recipe has built with only pip in the host section in the past, you likely should add setuptools to the host section of your recipe.

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

VeckoTheGecko commented 1 month ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 month ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

_{This message was generated by GitHub actions workflow run https://github.com/conda-forge/plasticparcels-feedstock/actions/runs/11103345671.}

VeckoTheGecko commented 1 month ago

Looks like the problem stems from the archive itself. In parcels we have a custom archiving configuration somewhat inline with setuptools_scm documentation, however that doesn't seem to be the case here. Hence when patching this configuration to properly use setuptools_scm it's incompatible with the already existing archive.

I think we're best off closing this, making a new release with updated archive config (+ build instructions from this PR), and then yank the old conda version