search

conda-forge / pluggy-feedstock

A conda-smithy repository for pluggy.
BSD 3-Clause "New" or "Revised" License
2 stars 13 forks source link

Fix recipe #17

Closed chrisburr closed 4 years ago

chrisburr commented 4 years ago

Checklist

chrisburr commented 4 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 4 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

chrisburr commented 4 years ago

I fairly sure this will be automatically added to the Python 3.8 migration after this PR is merged. If it isn't, ping me and I'll migrate it manually.

duncanmmacleod commented 4 years ago

@chrisburr, I think this is still needed, can you rebase and then merge?

chrisburr commented 4 years ago

I can rebased (and have) but I don't have the permissions needed to merge.

The Travis failure is https://github.com/conda-forge/status/issues/79 and shouldn't block this from being merged.

nicoddemus commented 4 years ago

@conda-forge-admin, please rerender

nicoddemus commented 4 years ago

I've updated the recipe to build everything on Azure. 👍

I will merge it right after this passes.

nicoddemus commented 4 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 4 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

nicoddemus commented 4 years ago

@conda-forge-admin, please rerender

chrisburr commented 4 years ago

@nicoddemus Ready to go!

For future reference, you can now add the "automerge" label to automatically merge when the CI passes

nicoddemus commented 4 years ago

Thanks @chrisburr!

For future reference, you can now add the "automerge" label to automatically merge when the CI passes

I'm a bit wary of that, because it will auto merge even if dependency pins change upstream (which means we should also update the pins on the recipe), which leads to technically broken conda packages.

nicoddemus commented 4 years ago

Ahh sorry, misunderstood you! I thought you meant enabling "auto merge" feature on the repository.

Didn't know about the label, thanks!