conda-forge / plumed-feedstock

A conda-smithy repository for plumed.
BSD 3-Clause "New" or "Revised" License
0 stars 9 forks source link

[DNM] Windows build attempt #32

Open mikemhenry opened 2 years ago

mikemhenry commented 2 years ago

Checklist

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

mikemhenry commented 2 years ago

supersedes pr #17

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

mikemhenry commented 2 years ago

Looks like I need to get gawk working on windows https://github.com/conda-forge/gawk-feedstock/pull/17

bollwyvl commented 2 years ago

You might be able to use the mingw64-built m2-gawk: this might be easier than getting a vc-based build working.

- gawk  # [not win]
- m2-gawk  # [win]
tonigi commented 2 years ago

If relevant https://github.com/conda-forge/plumed-feedstock/pull/31#issuecomment-1230284358

mikemhenry commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/plumed-feedstock/actions/runs/2969598969.

GiovanniBussi commented 2 years ago

@mikemhenry you can have a look at this as well which has been reported to compile.

As a separate note, I found some significant portability problems that could make the Windows version buggy. I think it's good to have a setup that compiles on conda, but I would not merge it until we have sorted out the most important bugs.

Since this is unrelated to conda, I would rather move the discussion here.

Notice that I have a test repository where, with @tonigi 's help, I managed to set up a fast mingw compilation of plumed which also runs the current tests on Windows. There are a number of failures now that might require some small modifications to the plumed code for portability.

mikemhenry commented 2 years ago

I think it's good to have a setup that compiles on conda, but I would not merge it until we have sorted out the most important bugs.

Sounds good! It is important AFAIK that we get things working on conda-forge so that we can get this package on FAH windows folders.

mikemhenry commented 2 years ago

Progress! It finds the header now, but new error:

checking for dirent.h... yes
checking for readdir... no
configure: error: compulsory function not found
mikemhenry commented 2 years ago

Looks like readdir just isn't something we can do on windows? It looks like a lot of stack overflow answers point to https://docs.microsoft.com/en-us/windows/win32/fileio/listing-the-files-in-a-directory?redirectedfrom=MSDN

mikemhenry commented 2 years ago

dirent.h should have it... https://github.com/win32ports/dirent_h https://www.mkssoftware.com/docs/man3/readdir.3.asp

mikemhenry commented 2 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 2 years ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/plumed-feedstock/actions/runs/3066281587.