Closed manics closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
conmon 2.0.31 PR here: https://github.com/conda-forge/conmon-feedstock/pull/10
@conda-forge-admin, please rerender
The --help
and --version
tests seemed to work but something else seemed to go wrong:
time="2022-01-18T22:54:25Z" level=debug msg="Using OCI runtime \"$PREFIX/bin/runc\""
time="2022-01-18T22:54:25Z" level=info msg="Found CNI network podman (type=bridge) at $PREFIX/etc/cni/net.d/87-podman.conflist"
time="2022-01-18T22:54:25Z" level=debug msg="Default CNI network name podman is unchangeable"
time="2022-01-18T22:54:25Z" level=warning msg="\"/\" is not a shared mount, this could cause issues or missing mounts with rootless containers"
cannot clone: Operation not permitted
Error: cannot re-exec process
Tests failed for podman-3.4.4-h9f03be5_0.tar.bz2 - moving package to /home/conda/feedstock_root/build_artifacts/broken
The build is run in docker, and I think we've hit https://github.com/containers/podman/issues/10802 (https://github.com/containers/podman/issues/10802#issuecomment-887852175)
Maybe also add :
azure: {store_build_artifacts: true}
So the built artifacts can be tested manually?
https://github.com/conda-forge/jupyterlab-feedstock/blob/master/conda-forge.yml#L6
The build script can read additional options set in an env-var https://github.com/conda-forge/podman-feedstock/blob/1f2c62fbe3b4263da8d5f7aa75011bef2ab49c42/.scripts/run_docker_build.sh#L67-L68
Adding --cap-add SYS_ADMIN
might work? I'll test locally when I get time.
@bollwyvl thanks for the suggestion, I've added it.
@conda-forge-admin, please rerender
Adding
--cap-add SYS_ADMIN
might work? I'll test locally when I get time
Maybe? Sounds like it might not be an option though :/
https://github.com/containers/podman/issues/10802#issuecomment-871389758
I'd be ok with not running the test. If we can get it to work great, but if not, we'll pick up any breakage if we're using it regularly and can publish a new build if required.
--cap-add
doesn't exist in docker build
, but it does exist in docker run
(which is used to build this podman package).
@conda-forge-admin, please rerender
Green!
Thanks @manics for getting this one over the line - great work!
Hopefully someone from @conda-forge/core will be able to merge shortly...
Thank you @beckermr !
Thanks from me too!
Checklist
0
(if the version changed)conda-smithy
(Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)This is a copy of @dhirschfeld's https://github.com/conda-forge/podman-feedstock/pull/13 (https://github.com/conda-forge/podman-feedstock/pull/13/commits/4fc896ca3a07f91272d0d3397a3bd92013624853) with these additions:
go-licenses
pathpodman ... info
I've managed to get this building in a container
quay.io/condaforge/linux-anvil-cos7-x86_64:latest
with commandconda build -c conda-forge -m .ci_support/linux_64_.yaml recipe/
, however this still fails at the testing stage: