conda-forge / podman-feedstock

A conda-smithy repository for podman.
BSD 3-Clause "New" or "Revised" License
1 stars 7 forks source link

podman v4.3.0 #28

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 2 years ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Dependency Analysis

We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3282659151, please use this URL for debugging.

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

manics commented 2 years ago

One day, in the distant future, an auto-update may actually succeed. But not today.

...
Applying patch: /home/conda/recipe_root/0001-Add-missing-defines-for-CentOS-6.patch
Applying patch: /home/conda/recipe_root/0001-Add-missing-defines-for-CentOS-6.patch with args:
['-Np1', '-i', '/tmp/tmp0yfjjuvx/0001-Add-missing-defines-for-CentOS-6.patch.native', '--binary']
checking file pkg/rootless/rootless_linux.c
Applying patch: /home/conda/recipe_root/0002-relative-paths-for-system-config-and-binaries.patch
Applying patch: /home/conda/recipe_root/0002-relative-paths-for-system-config-and-binaries.patch with args:
['-Np1', '-i', '/tmp/tmpt77japql/0002-relative-paths-for-system-config-and-binaries.patch.native', '--binary']
checking file vendor/github.com/containers/common/pkg/config/config.go
Hunk #1 succeeded at 22 (offset 1 line).
Hunk #2 succeeded at 775 (offset 20 lines).
Hunk #3 succeeded at 1370 (offset 88 lines).
checking file vendor/github.com/containers/common/pkg/config/default.go
Hunk #1 succeeded at 149 (offset 9 lines).
Hunk #2 FAILED at 168.
Hunk #3 succeeded at 188 (offset 11 lines).
1 out of 3 hunks FAILED
checking file vendor/github.com/containers/image/v5/pkg/sysregistriesv2/system_registries_v2.go
checking file vendor/github.com/containers/image/v5/signature/policy_config.go
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.
Error was: 
Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmpt77japql/0002-relative-paths-for-system-config-and-binaries.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
...
dhirschfeld commented 1 year ago

CI passes so I'm happy to merge. Will hold off for a bit in case you wanted to push any more commits. In general I'm happy for you to merge if CI passes, or just use the automerge label.

manics commented 1 year ago

Thanks! I usually try to review the CI logs for patches which I haven't tested locally.

https://dev.azure.com/conda-forge/feedstock-builds/_build/results?buildId=609190&view=logs&j=656edd35-690f-5c53-9ba3-09c10d0bea97&t=e5c8ab1d-8ff9-5cae-b332-e15ae582ed2d&l=1300

store:
  configFile: /home/conda/.config/containers/storage.conf

I don't think this is introduced by this update but it's something I noticed.... do you think this should be $PREFIX/share/containers/storage.conf to match the other configuration files which have been patched to be under $PREFIX, or do you think this is fine?

manics commented 1 year ago

Opened #30 for deciding the location of storage.conf