Closed regro-cf-autotick-bot closed 2 years ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
One day, in the distant future, an auto-update may actually succeed. But not today.
...
Applying patch: /home/conda/recipe_root/0001-Add-missing-defines-for-CentOS-6.patch
Applying patch: /home/conda/recipe_root/0001-Add-missing-defines-for-CentOS-6.patch with args:
['-Np1', '-i', '/tmp/tmp0yfjjuvx/0001-Add-missing-defines-for-CentOS-6.patch.native', '--binary']
checking file pkg/rootless/rootless_linux.c
Applying patch: /home/conda/recipe_root/0002-relative-paths-for-system-config-and-binaries.patch
Applying patch: /home/conda/recipe_root/0002-relative-paths-for-system-config-and-binaries.patch with args:
['-Np1', '-i', '/tmp/tmpt77japql/0002-relative-paths-for-system-config-and-binaries.patch.native', '--binary']
checking file vendor/github.com/containers/common/pkg/config/config.go
Hunk #1 succeeded at 22 (offset 1 line).
Hunk #2 succeeded at 775 (offset 20 lines).
Hunk #3 succeeded at 1370 (offset 88 lines).
checking file vendor/github.com/containers/common/pkg/config/default.go
Hunk #1 succeeded at 149 (offset 9 lines).
Hunk #2 FAILED at 168.
Hunk #3 succeeded at 188 (offset 11 lines).
1 out of 3 hunks FAILED
checking file vendor/github.com/containers/image/v5/pkg/sysregistriesv2/system_registries_v2.go
checking file vendor/github.com/containers/image/v5/signature/policy_config.go
Warning: failed to download source. If building, will try again after downloading recipe dependencies.
Error was:
Command '['/opt/conda/bin/patch', '--no-backup-if-mismatch', '--batch', '-Np1', '-i', '/tmp/tmpt77japql/0002-relative-paths-for-system-config-and-binaries.patch.native', '--binary', '--dry-run']' returned non-zero exit status 1.
...
CI passes so I'm happy to merge. Will hold off for a bit in case you wanted to push any more commits. In general I'm happy for you to merge if CI passes, or just use the automerge
label.
Thanks! I usually try to review the CI logs for patches which I haven't tested locally.
store:
configFile: /home/conda/.config/containers/storage.conf
I don't think this is introduced by this update but it's something I noticed.... do you think this should be $PREFIX/share/containers/storage.conf
to match the other configuration files which have been patched to be under $PREFIX
, or do you think this is fine?
Opened #30 for deciding the location of storage.conf
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Dependency Analysis
We couldn't run dependency analysis due to an internal error in the bot. :/ Help is very welcome!
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3282659151, please use this URL for debugging.