search

conda-forge / poetry-feedstock

A conda-smithy repository for poetry.
BSD 3-Clause "New" or "Revised" License
3 stars 13 forks source link

How to add poetry-plugin-export #65

Closed maresb closed 2 years ago

maresb commented 2 years ago

Comment:

I would like to build the latest beta version v1.2.0b2. However it now depends on ^1.0.4 of a package called poetry-plugin-export. In a partially circular dependency, that relies on poetry ^1.2.0b1.

To complicate matters further, poetry-plugin-export doesn't have a license file.

I think I should make a new feedstock for poetry-plugin-export, but that must target the dev channel sources. I'm not sure if that's allowed in staged-recipes.

As you can see, the situation is unfortunately rather complicated. Any suggestions?

ocefpaf commented 2 years ago

As you can see, the situation is unfortunately rather complicated. Any suggestions?

Your plan sounds good. Note that poetry-plugin-export depends on poetry-core and not poetry. That should help you with the circular dependency.

xylar commented 2 years ago

@maresb, it is fine to make a new recipe for a non-release very of a package. Just make sure it goes to a dev label (poetry_dev would make sense in this case). I'll post a link to an example recipe soon.

xylar commented 2 years ago

Also, feel free to make me a maintainer if you want.

maresb commented 2 years ago

Thanks @xylar, let's give it a try. However, I think there is no point in starting before they create a LICENSE file.

xylar commented 2 years ago

Here's the example I had in mind https://github.com/conda-forge/staged-recipes/pull/18565

Just make sure you have the conda_build_config.yaml

xylar commented 2 years ago

@maresb, yes, you're right about that. If you can find out what license they want to include in some official way, you can include it in the recipe for now. But no license is a show stopper.

maresb commented 2 years ago

Ah, that's great! For some reason I couldn't build locally (neither conda build nor conda mambabuild) because it didn't seem to be parsing my conda_build_config.yaml.

maresb commented 2 years ago

They declared MIT, but I feel uneasy producing a LICENSE file for someone else.

xylar commented 2 years ago

You're right. If they add it to their repo, we could copy it into the recipe so we don't have to wait for a release. But to add a license file for somewhere else would be iffy.

maresb commented 2 years ago

This exists now at https://github.com/conda-forge/poetry-plugin-export-feedstock :tada: