MNT: Add noarch: python

conda-forge / poetry-feedstock

A conda-smithy repository for poetry.

BSD 3-Clause "New" or "Revised" License

3 stars 13 forks source link

MNT: Add noarch: python #76

Closed conda-forge-linter closed 1 year ago

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I've made the recipe noarch: python as instructed in #75.

Here's a checklist to do before merging.

[ ] Bump the build number if needed.

Fixes #75

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

noarch packages can't have selectors. If the selectors are necessary, please remove noarch: python.
noarch: python recipes are required to have a lower bound on the python version. Typically this means putting python >=3.6 in both host and run but you should check upstream for the package's Python compatibility.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

maresb commented 1 year ago

I'm wondering: was importlib-metadata the only thing blocking noarch? :man_facepalming: :joy:

Edit: looking at the initial commit, it had

    - virtualenv >=16.0,<17.0  # [py27]
    - typing >=3.6,<4.0  # [py<35]
    - pathlib2 >=2.3,<3.0  # [py<35]

I'm just wondering why I didn't notice this myself... I guess seeing the build section made me assume that something required compilation. Now I know for next time! Thanks @isuruf for pointing this out!

maresb commented 1 year ago

Hmm, Poetry supports Python 3.7. Shall we readd importlib-metadata and pin to >=3.7?

isuruf commented 1 year ago

We have dropped support for python=3.7 in conda-forge and this package will not build for 3.7 anymore after a rerender. So, it's fine to have the same constraint in a noarch: python package.

maresb commented 1 year ago

It seems to me like this could result in confusion for someone working on an older 3.7 Conda environment who tries to upgrade Poetry. (But still thanks for clarifying this policy!)

BTW, newer versions of Poetry explicitly depend on importlib-metadata for py<310, so we're going to have to readd it regardless, and in that case we might as well relax the pin to include py37.

I'll make the change, but feel free to revert in case you object.