Closed regro-cf-autotick-bot closed 1 year ago
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
Hi! This is the friendly automated conda-forge-linting service.
I wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found some lint.
Here's what I've got...
For recipe:
requirements: run: cachecontrol = >=0.12.9,<0.13
should not contain a space between relational operator and the version, i.e. cachecontrol =>=0.12.9,<0.13
Hi! This is the friendly automated conda-forge-linting service.
I just wanted to let you know that I linted all conda-recipes in your PR (recipe
) and found it was in an excellent condition.
@conda-forge-admin, please rerender
@ocefpaf and @maresb, please have a careful look. There are a lot of dependency changes here and I think we can't get away with noarch anymore.
https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/8 and https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/9 went to poetry_dev
instead of main
and need to be rebuilt for main
.
Need to wait for a poetry-core
1.4.0 build
trove-classifiers
(https://pypi.org/project/trove-classifiers/) has not been built on conda-forge and needs a staged recipe.
Regarding trove-classifiers
:
https://github.com/conda-forge/staged-recipes/pull/21504
Regarding poetry-core: https://github.com/conda-forge/poetry-core-feedstock/pull/35
export SRC_DIR=/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work
/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work/conda_build.sh: line 4: /Users/runner/miniforge3/conda-bld/poetry_1670754476345/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin/python: Bad CPU type in executable
Any ideas?
I suspect we're missing something from cross-compilation on arm64. We should be able to compare with some other generic recipe with osx-arm64 enabled. I have to go right now, be back in an hour or so.
Perfect, thanks @maresb!
Huh? What's going on? Our commits here have landed in main
~without a merge commit~, and this PR is still open.
EDIT: Sorry, I seem to have been confused. I think I was looking at the file history, there is a merge commit.
While the automerge action was running, there was a 500 failure in the GH API call to the merge endpoint.
I can open a PR in the automerge repo to try and give a better stack trace. Perhaps for here we should run @conda-forge-admin, please rerun bot to clear things up and see where that leaves us. Then if there's no build, open a new PR with an empty commit?
Ah, crap! I meant to remove the @
BTW I tracked down the implicit lockfile
dependency to https://github.com/conda-forge/cachecontrol-feedstock/issues/15. That was really confusing, since I wasn't expecting a yanked package!
I just reset the head on main
. Let's merge this by hand after checks pass, and then I'll open a PR in conda-forge/automerge-action.
then I'll open a PR in conda-forge/automerge-action.
That's not what I had in mind and not safe here. The automerge bot is only for recipes where the dependencies very rarely change. I just wanted to automerge this particular PR, but no need now
Thanks for merging!
I think I wasn't clear about what I meant in my previous message. I wasn't proposing enabling automerge here. Rather, I noticed a bug in the stack trace of the automerge-action which I'd like to fix with a PR.
Sorry, I misunderstood. I see that now what you meant. The risks of girhubbing with my phone...
If the only reason this isn't noarch anymore is dependencies, you could do something like outlined here: https://github.com/conda-forge/conda-forge.github.io/pull/1839
We can give that a try. It would certainly be nice to go back to to noarch.
Great, I’ll make a PR tomorrow
Do we know if it's safe to install tomli
everywhere, including 3.11?
Do we know if it's safe to install tomli everywhere, including 3.11?
Looking into it...
I looks like it. tomli
is noarch on conda-forge and doesn't exclude 3.11. Then, there are these lines in poetry:
https://github.com/python-poetry/poetry/blob/1.3.0/src/poetry/utils/_compat.py#L11-L15
So it just won't get used in py 3.11.
It is very likely that the current package version for this feedstock is out of date.
Checklist before merging this PR:
license_file
is packagedInformation about this PR:
please add bot automerge
in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.bot-rerun
label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have theconda-forge-admin
add it for you.Closes: #72 Closes: #73 Closes: #74
Pending Dependency Version Updates
Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.
Dependency Analysis
Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add
bot: inspection: false
to yourconda-forge.yml
. If you encounter issues with this feature please ping the bot teamconda-forge/bot
.Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.
Packages found by source code inspection but not in the meta.yaml:
Packages found in the meta.yaml but not found by source code inspection:
This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3661965370, please use this URL for debugging.