conda-forge / poetry-feedstock

A conda-smithy repository for poetry.
BSD 3-Clause "New" or "Revised" License
3 stars 13 forks source link

poetry v1.3.0 #77

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

It is very likely that the current package version for this feedstock is out of date.

Checklist before merging this PR:

Information about this PR:

  1. Feel free to push to the bot's branch to update this PR if needed.
  2. The bot will almost always only open one PR per version.
  3. The bot will stop issuing PRs if more than 3 version bump PRs generated by the bot are open. If you don't want to package a particular version please close the PR.
  4. If you want these PRs to be merged automatically, make an issue with code>@conda-forge-admin,</codeplease add bot automerge in the title and merge the resulting PR. This command will add our bot automerge feature to your feedstock.
  5. If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

Closes: #72 Closes: #73 Closes: #74

Pending Dependency Version Updates

Here is a list of all the pending dependency version updates for this repo. Please double check all dependencies before merging.

Name Upstream Version Current Version
poetry-core 1.4.0 Anaconda-Server Badge

Dependency Analysis

Please note that this analysis is highly experimental. The aim here is to make maintenance easier by inspecting the package's dependencies. Importantly this analysis does not support optional dependencies, please double check those before making changes. If you do not want hinting of this kind ever please add bot: inspection: false to your conda-forge.yml. If you encounter issues with this feature please ping the bot team conda-forge/bot.

Analysis by source code inspection shows a discrepancy between it and the the package's stated requirements in the meta.yaml.

Packages found by source code inspection but not in the meta.yaml:

Packages found in the meta.yaml but not found by source code inspection:

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/autotick-bot/actions/runs/3661965370, please use this URL for debugging.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

conda-forge-linter commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 1 year ago

@conda-forge-admin, please rerender

xylar commented 1 year ago

@ocefpaf and @maresb, please have a careful look. There are a lot of dependency changes here and I think we can't get away with noarch anymore.

xylar commented 1 year ago

https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/8 and https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/9 went to poetry_dev instead of main and need to be rebuilt for main.

Need to wait for a poetry-core 1.4.0 build

trove-classifiers (https://pypi.org/project/trove-classifiers/) has not been built on conda-forge and needs a staged recipe.

xylar commented 1 year ago

regarding poetry-plugin-export: https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/11 https://github.com/conda-forge/poetry-plugin-export-feedstock/pull/12

xylar commented 1 year ago

Regarding trove-classifiers: https://github.com/conda-forge/staged-recipes/pull/21504

xylar commented 1 year ago

Regarding poetry-core: https://github.com/conda-forge/poetry-core-feedstock/pull/35

xylar commented 1 year ago
export SRC_DIR=/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work
/Users/runner/miniforge3/conda-bld/poetry_1670754476345/work/conda_build.sh: line 4: /Users/runner/miniforge3/conda-bld/poetry_1670754476345/_h_env_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_placehold_pl/bin/python: Bad CPU type in executable

Any ideas?

maresb commented 1 year ago

I suspect we're missing something from cross-compilation on arm64. We should be able to compare with some other generic recipe with osx-arm64 enabled. I have to go right now, be back in an hour or so.

xylar commented 1 year ago

Perfect, thanks @maresb!

maresb commented 1 year ago

Huh? What's going on? Our commits here have landed in main ~without a merge commit~, and this PR is still open.

EDIT: Sorry, I seem to have been confused. I think I was looking at the file history, there is a merge commit.

maresb commented 1 year ago

While the automerge action was running, there was a 500 failure in the GH API call to the merge endpoint.

I can open a PR in the automerge repo to try and give a better stack trace. Perhaps for here we should run @conda-forge-admin, please rerun bot to clear things up and see where that leaves us. Then if there's no build, open a new PR with an empty commit?

maresb commented 1 year ago

Ah, crap! I meant to remove the @

maresb commented 1 year ago

BTW I tracked down the implicit lockfile dependency to https://github.com/conda-forge/cachecontrol-feedstock/issues/15. That was really confusing, since I wasn't expecting a yanked package!

maresb commented 1 year ago

I just reset the head on main. Let's merge this by hand after checks pass, and then I'll open a PR in conda-forge/automerge-action.

xylar commented 1 year ago

then I'll open a PR in conda-forge/automerge-action.

That's not what I had in mind and not safe here. The automerge bot is only for recipes where the dependencies very rarely change. I just wanted to automerge this particular PR, but no need now

maresb commented 1 year ago

Thanks for merging!

I think I wasn't clear about what I meant in my previous message. I wasn't proposing enabling automerge here. Rather, I noticed a bug in the stack trace of the automerge-action which I'd like to fix with a PR.

xylar commented 1 year ago

Sorry, I misunderstood. I see that now what you meant. The risks of girhubbing with my phone...

BastianZim commented 1 year ago

If the only reason this isn't noarch anymore is dependencies, you could do something like outlined here: https://github.com/conda-forge/conda-forge.github.io/pull/1839

xylar commented 1 year ago

We can give that a try. It would certainly be nice to go back to to noarch.

BastianZim commented 1 year ago

Great, I’ll make a PR tomorrow

BastianZim commented 1 year ago

Do we know if it's safe to install tomli everywhere, including 3.11?

xylar commented 1 year ago

Do we know if it's safe to install tomli everywhere, including 3.11?

Looking into it...

xylar commented 1 year ago

I looks like it. tomli is noarch on conda-forge and doesn't exclude 3.11. Then, there are these lines in poetry: https://github.com/python-poetry/poetry/blob/1.3.0/src/poetry/utils/_compat.py#L11-L15 So it just won't get used in py 3.11.