search

conda-forge / polars-feedstock

A conda-smithy repository for polars.
BSD 3-Clause "New" or "Revised" License
10 stars 19 forks source link

bump to 1.4.0 #257

Closed conda-forge-admin closed 2 months ago

conda-forge-admin commented 3 months ago

Hi! This is the friendly automated conda-forge-webservice.

I've started a version update as instructed in conda-forge/polars-feedstock#256.

I'm currently searching for new versions and will update this PR shortly if I find one! Thank you for waiting!

Fixes conda-forge/polars-feedstock#256

conda-forge-webservices[bot] commented 3 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

pavelzw commented 3 months ago

@conda-forge-admin, please rerender

pavelzw commented 3 months ago

let's skip osx for now :( xref conda-forge/rust-feedstock#204

timkpaine commented 3 months ago

why are you dropping OSX?

pavelzw commented 3 months ago

https://github.com/conda-forge/polars-feedstock/pull/253#issuecomment-2259797774 we couldn't figure out why the build is failing with a segfault and thought that it would make more sense to release the non-osx versions for now instead of blocking everything because of this

timkpaine commented 3 months ago

There are more people that rely on this feedstock than just @quantco and their customers. We should be a bit more hesitant to randomly drop OS's

pavelzw commented 3 months ago

we couldn't reproduce the issue locally unfortunately

timkpaine commented 3 months ago

and? it was a rush to break the auto tick mechanism in the first place, I think we can take a few days to investigate further as we get the releases back on track.

0xbe7a commented 3 months ago

I investigated this but couldn't reproduce it locally. I pinged for support as this seems like a problem with the clang-toolchain. This isn't about preferred support, OS-X is our primary development platform and we very much want to get this back working asap. However I don't see reasons why this should block all other builds.

timkpaine commented 3 months ago

At a first pass it looks like its going OOM during linking no? Can't we just cross compile which IIR we already do for windows? I dont know if there's any other mechanism of increasing memory or decreasing llvm memory usage

0xbe7a commented 3 months ago

Regarding the build variants: There was an open feature request (https://github.com/conda-forge/polars-feedstock/issues/186) that requested these variants to be available. I saw your feedback on the PR and addressed it, but received no further response. I still believe it's the most elegant approach. We fixed the autotick-bot compatibility after discovering it was broken.

There is a substantial user base for Polars, and many people, such as those on Discord, are looking forward to each release. I believe there is nothing wrong with getting new versions out for the majority of the user base and then fixing issues like this in subsequent builds.

0xbe7a commented 2 months ago

At a first pass it looks like its going OOM during linking no? Can't we just cross compile which IIR we already do for windows?

It appears the same issue is occurring in at least one other feedstock, as seen in conda-forge/rust-feedstock#204, so i am not sure it's really a OOM problem. Additionally, I tried to get cross-compilation from linux-64 to osx working in conda-forge/polars-feedstock#253, but it seems that the CMake toolchain needs additional work. I couldn't find any other feedstock on conda-forge that is successfully cross-compiling from linux-64 to osx. I'm sure the issue might be more obvious to someone with more familiarity with the compiler-activation infrastructure, but it seems that I'm not able to "just" cross-compile.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I was trying to look for recipes to lint for you, but it appears we have a merge conflict. Please try to merge or rebase with the base branch to resolve this conflict.

Please ping the 'conda-forge/core' team (using the @ notation in a comment) if you believe this is a bug.

conda-forge-webservices[bot] commented 2 months ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe/meta.yaml) and found it was in an excellent condition.

github-actions[bot] commented 2 months ago

Hi! This is the friendly conda-forge automerge bot!

I considered the following status checks when analyzing this PR:

Thus the PR was passing and merged! Have a great day!