Update to v22.04.0 - Githubissues

conda-forge / poppler-feedstock

A conda-smithy repository for poppler.

BSD 3-Clause "New" or "Revised" License

22 stars 16 forks source link

Update to v22.04.0 #127

Closed xylar closed 2 years ago

xylar commented 2 years ago

Checklist

[x] Used a personal fork of the feedstock to propose changes
[ ] Bumped the build number (if the version is unchanged)
[x] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

closes #126

conda-forge-linter commented 2 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

xylar commented 2 years ago

@conda-forge-admin, please rerender

xylar commented 2 years ago

@ocefpaf, @pkgw or @xhochy, you all have more experience with this package than me, I think. Could you verify that no dependencies need to change?

xylar commented 2 years ago

Error for OSX:

[198/258] Generating poppler-enums.h
FAILED: glib/poppler-enums.h $SRC_DIR/build/glib/poppler-enums.h 
cd $SRC_DIR/glib && $PREFIX/bin/python3 $PREFIX/bin/glib-mkenums --template poppler-enums.h.template poppler-action.h poppler-date.h poppler-document.h poppler-page.h poppler-attachment.h poppler-form-field.h poppler-annot.h poppler-layer.h poppler-movie.h poppler-media.h poppler.h poppler-structure-element.h > $SRC_DIR/build/glib/poppler-enums.h
/bin/sh: $PREFIX/bin/python3: Bad CPU type in executable

For Windows, it looks like a patch needs either to be fixed or removed.

pkgw commented 2 years ago

OK, I've pushed some commits that attempt to fix the build issues. It looks like upstream has integrated some patches that aim to fix the MSVC/GooString/std::string C++ cross-library symbol clashing problem — we should test that the resulting artifacts are still OK from that standpoint. I am not sure if there's an easier way to do that than running a custom GDAL build, though.

pkgw commented 2 years ago

I can get a Windows package to compile but I'm failing to build GDAL downstream, for reasons that look like they're related to the C++ string stuff:

frmts\pdf\pdfdataset.cpp(4329):
error C2664: 'PDFDoc::PDFDoc(void)': cannot convert argument 1 from 'VSIPDFFileStream *' to 'std::unique_ptr<GooString,std::default_delete<_Ty>> &&'
note: Reason: cannot convert from 'VSIPDFFileStream *' to 'std::unique_ptr<GooString,std::default_delete<_Ty>>'
note: No constructor could take the source type, or constructor overload resolution was ambiguous

pkgw commented 2 years ago

OK, actually, I think that my hacked gdal build was actually misconfigured before. I tried again and the PDF stuff seems to have worked — I ran into a build failure relating to libblosc and libzstd but I don't think it has anything to do with Poppler.

@conda-forge/poppler anyone else want to look this over?

xylar commented 2 years ago

Thanks @pkgw. Merge when you're ready