Update to v23.01 - Githubissues

conda-forge / poppler-feedstock

A conda-smithy repository for poppler.

BSD 3-Clause "New" or "Revised" License

22 stars 16 forks source link

Update to v23.01 #139

Closed Fdawgs closed 1 year ago

Fdawgs commented 1 year ago

Checklist

[X] Used a personal fork of the feedstock to propose changes
[X] Bumped the build number (if the version is unchanged)
[X] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[ ] Ensured the license file is being packaged.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

Fdawgs commented 1 year ago

@conda-forge-admin, please rerender

github-actions[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-webservice.

I tried to rerender for you, but it looks like there was nothing to do.

This message was generated by GitHub actions workflow run https://github.com/conda-forge/poppler-feedstock/actions/runs/3930771080.

pkgw commented 1 year ago

Looks like a Windows patch needs updating:

Applying patch: D:\a\1\s\recipe\exportsymbols.patch with args:
['-Np1', '-i', 'C:\\Users\\VSSADM~1\\AppData\\Local\\Temp\\tmp88kerrr_\\exportsymbols.patch.native', '--binary']
checking file CMakeLists.txt
Hunk #1 FAILED at 573.
1 out of 1 hunk FAILED
checking file cpp/CMakeLists.txt
Hunk #1 succeeded at 23 with fuzz 1 (offset -1 lines).
checking file poppler/GlobalParams.h
checking file poppler/PDFDocEncoding.h
Warning: failed to download source.  If building, will try again after downloading recipe dependencies.

This may be very straightforward to fix. I'll try to take a look at this soon.

Fdawgs commented 1 year ago

Thanks @pkgw !