Enable macOS build - Githubissues

conda-forge / portaudio-feedstock

A conda-smithy repository for portaudio.

BSD 3-Clause "New" or "Revised" License

2 stars 9 forks source link

Enable macOS build #12

Closed traversaro closed 3 years ago

traversaro commented 3 years ago

I incorporated the script from https://github.com/AnacondaRecipes/portaudio-feedstock and added a patch to disable -Werror on macOS.

Fix https://github.com/conda-forge/portaudio-feedstock/issues/2 .

Checklist

[x] Used a personal fork of the feedstock to propose changes
[x] Bumped the build number (if the version is unchanged)
[ ] Reset the build number to 0 (if the version changed)
[x] Re-rendered with the latest conda-smithy (Use the phrase code>@<space/conda-forge-admin, please rerender in a comment in this PR for automated rerendering)
[x] Ensured the license file is being packaged.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:

License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.

Documentation on acceptable licenses can be found here.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

I do have some suggestions for making it better though...

For recipe:
* License is not an SPDX identifier (or a custom LicenseRef) nor an SPDX license expression.
Documentation on acceptable licenses can be found here.

Fixed by switching to MIT, as per PortAudio website (http://www.portaudio.com/license.html) "In terms of legal compatibility, the PortAudio licence is now a plain MIT licence" .

traversaro commented 3 years ago

@conda-forge-admin, please rerender

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I wanted to let you know that I linted all conda-recipes in your PR (recipe) and found some lint.

Here's what I've got...

For recipe:

The source section contained an unexpected subsection name. patch is not a valid subsection name.

conda-forge-linter commented 3 years ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

traversaro commented 3 years ago

@conda-forge-admin, please rerender

github-actions[bot] commented 3 years ago

Hi! This is the friendly automated conda-forge-webservice. I tried to rerender for you, but it looks like there was nothing to do.

traversaro commented 3 years ago

@conda-forge/portaudio this PR should be ready for review. If you want, I will be also happy to add myself as a maintainer.

jakirkham commented 3 years ago

Thanks for adding this Silvio! 😄