conda-forge / prismatic_split-feedstock

A conda-smithy repository for prismatic_split.
BSD 3-Clause "New" or "Revised" License
3 stars 5 forks source link

Rebuild for CUDA 12 #38

Closed regro-cf-autotick-bot closed 1 year ago

regro-cf-autotick-bot commented 1 year ago

This PR has been triggered in an effort to update cuda120.

Notes and instructions for merging this PR:

  1. Please merge the PR only after the tests have passed.
  2. Feel free to push to the bot's branch to update this PR if needed.

Please note that if you close this PR we presume that the feedstock has been rebuilt, so if you are going to perform the rebuild yourself don't close this PR until the your rebuild has been merged.


Here are some more details about this specific migrator:

The transition to CUDA 12 SDK includes new packages for all CUDA libraries and build tools. Notably, the cudatoolkit package no longer exists, and packages should depend directly on the specific CUDA libraries (libcublas, libcusolver, etc) as needed. For an in-depth overview of the changes and to report problems see this issue. Please feel free to raise any issues encountered there. Thank you! :pray:


If this PR was opened in error or needs to be updated please add the bot-rerun label to this PR. The bot will close this PR and schedule another one. If you do not have permissions to add this label, you can use the phrase code>@<space/conda-forge-admin, please rerun bot in a PR comment to have the conda-forge-admin add it for you.

This PR was created by the regro-cf-autotick-bot. The regro-cf-autotick-bot is a service to automatically track the dependency graph, migrate packages, and propose package version updates for conda-forge. Feel free to drop us a line if there are any issues! This PR was generated by https://github.com/regro/cf-scripts/actions/runs/5142419721, please use this URL for debugging.

conda-forge-webservices[bot] commented 1 year ago

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

jakirkham commented 1 year ago

Seeing the following error on CI:

CMake Error at /home/conda/feedstock_root/build_artifacts/prismatic_split_1685611790359/_build_env/share/cmake-3.26/Modules/FindCUDA.cmake:861 (message):
  Specify CUDA_TOOLKIT_ROOT_DIR

Looking at the recipe, am seeing lines like this that reference $CUDA_HOME

https://github.com/conda-forge/prismatic_split-feedstock/blob/5502811254b8390279342a9077901276d91b1c40/recipe/combined_build_install.sh#L39

https://github.com/conda-forge/prismatic_split-feedstock/blob/5502811254b8390279342a9077901276d91b1c40/recipe/build_pyprismatic.sh#L10

As of CUDA 12, the headers and libraries are now added to $PREFIX. So there is no longer a $CUDA_HOME variable. Think either only passing $CUDA_HOME when set or using something like this would do the trick:

"${CUDA_HOME:-$PREFIX}"

Edit: For more info about the CUDA 12 bringup, please see issue ( https://github.com/conda-forge/conda-forge.github.io/issues/1963 )

regro-cf-autotick-bot commented 1 year ago

I see that this PR has conflicts, and I'm the only committer. I'm going to close this PR and will make another one as appropriate. This was generated by https://github.com/regro/cf-scripts/actions/runs/5948045741

jakirkham commented 1 year ago

Superseded by PR: https://github.com/conda-forge/prismatic_split-feedstock/pull/44