search

conda-forge / prody-feedstock

A conda-smithy repository for prody.
BSD 3-Clause "New" or "Revised" License
0 stars 5 forks source link

shouldn't Python be pinned to <3.12? #33

Open diogomart opened 3 months ago

diogomart commented 3 months ago

Comment:

Prody doesn't build on 3.12, but the conda-forge recipe doesn't know about it and tries to build on 3.12, causing trouble for downstream packages.

jamesmkrieger commented 3 months ago

Thanks. How do we stop that? @simonbray

jamesmkrieger commented 2 months ago

Ideally it should be pinned to < 3.11 as some things may only work up to 3.10

jamesmkrieger commented 2 months ago

Thanks. How do we stop that? @simonbray

Would we just change https://github.com/conda-forge/prody-feedstock/blob/dde48dbb898f96d74797cac834de23cda5032df5/recipe/meta.yaml#L24?

diogomart commented 2 months ago

We've also noticed errors arising from pyparsing > 3.0 https://github.com/forlilab/Meeko/issues/108

jamesmkrieger commented 2 months ago

We've also noticed errors arising from pyparsing > 3.0 forlilab/Meeko#108

Now we have this inside prody’s pyproject.toml and setup.py requires = ["setuptools", "wheel", "numpy>=1.10,<1.25", "pyparsing<=3.1.1", "scipy<=1.13.1"]

jamesmkrieger commented 2 months ago

That’s the pyproject.toml one. In setup.py, we have something similar that includes biopython

jamesmkrieger commented 2 months ago

It looks like I can't pin the python version but hopefully it just gets pinned automatically by pinning the numpy version

jamesmkrieger commented 2 months ago

oh, actually, I've got it

diogomart commented 2 months ago

@jamesmkrieger thank you!

jamesmkrieger commented 2 months ago

You're welcome. Please let me know if there are any problems.

jamesmkrieger commented 2 months ago

Actually, this fix isn't good enough because we don't get a v2.4.1 for OS X